Re: [FFmpeg-devel] [PATCH v2 1/4] avfilter/af_volumedetect.c: Move logdb function

[Thilo Borgmann via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

On 29.06.24 21:54, Yigithan Yigit wrote:
> 
>> On 29 Jun 2024, at 22:22, Rémi Denis-Courmont <remi@remlab.net> wrote:
>>
>> Le perjantaina 28. kesäkuuta 2024, 23.15.20 EEST Yigithan Yigit a écrit :
>>> ---
>>> libavfilter/af_volumedetect.c | 20 ++++++++++----------
>>> 1 file changed, 10 insertions(+), 10 deletions(-)
>>> diff --git a/libavfilter/af_volumedetect.c b/libavfilter/af_volumedetect.c
>>> index 8b001d1cf2..327801a7f9 100644
>>> --- a/libavfilter/af_volumedetect.c
>>> +++ b/libavfilter/af_volumedetect.c
>>> @@ -24,6 +24,8 @@
>>> #include "avfilter.h"
>>> #include "internal.h"
>>> +#define MAX_DB 91
>>> +
>>> typedef struct VolDetectContext {
>>>     /**
>>>      * Number of samples at each PCM value.
>>> @@ -33,6 +35,14 @@ typedef struct VolDetectContext {
>>>     uint64_t histogram[0x10001];
>>> } VolDetectContext;
>>> +static inline double logdb(uint64_t v)
>>> +{
>>> +    double d = v / (double)(0x8000 * 0x8000);
>>
>> ldexp(v, -30) ?
> 
> That was the original code that already written. Should I change?

Not here. Keep the move patch as-is.

You can test if ldexp() is equal and if so, add another patch to the 
patchset changing the function to utilize ldexp().

-Thilo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".