From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8535245EE7 for ; Mon, 17 Apr 2023 15:15:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4EBBE68BE3D; Mon, 17 Apr 2023 18:15:17 +0300 (EEST) Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34ACA680C25 for ; Mon, 17 Apr 2023 18:15:10 +0300 (EEST) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1878504c22aso17330535fac.8 for ; Mon, 17 Apr 2023 08:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681744508; x=1684336508; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jpGimc6aX4QjUHbW9+GVUBirIt1uJBRkQnxuu7bimJ4=; b=sUgV+MjuJKGEo9mcs0CvuE1n2FVrKLj4PZj8WocBJhcdqQ8w7se7aWI1IDJYSpt2kk +6PXGHk7Axcpqrz2tBC9AOvQf3HxXMoOTsd4YWzyx1AoAWz2Wb3jFNEZw4w5STJu5AY6 Ib6j6bITrcHrmBnAXB+oS/vEV11Lnr61+MfaRdmbn4LkPbfOZgPaGijlK9oSggUXEUYz jMEmKecwIOgfFNxsbmI5HFwIGFJGkNeuxwUUgKvbNssG9StxKpD8ExqJNM7/L1Bgcp+7 WRAOcvWBC5fihdsLZKHtlA+oB49OYs2TkVBZ+ddywS35PvNSr3EdjNt6RACmAVfP0UYv TL2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681744508; x=1684336508; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jpGimc6aX4QjUHbW9+GVUBirIt1uJBRkQnxuu7bimJ4=; b=ZQop7dMOZ340IdqNUmwyolNPehne256VLzeoT0+mkmUXTzP3W+KUhkVUaY+G6A0/Gr S8SpCUwpydVEzSqFHJigI3e7vLuuwW60Nr76q94f0osG+IioMK5NLLERsCPbBxNvqIc7 5/PQYGWhDD+uQ/UJdo2maMVscW7KiQXYQGFbZ/UL8t5uXYFhY5vF2j03zZPUdLXWpwgT 1iFTk+yTxmMf6cAbDZzulCJSMToKcPFp2+6chesiKqd4gBRuAbGAtN334CAYHzlMsEbL hkqws4apHsBd995T+bPME/GVgAt9l8nbuw8PLGl+1KCJYVE8+rwNrjATxYCszFzwAXqn dwyg== X-Gm-Message-State: AAQBX9dQX++Ts24Eh+IXOodTw6yfiUHCnHPUGBtcgaHtKivyiyJCxz9k YNNqjVAySI9PI6SOrOKq9uqKsib996A= X-Google-Smtp-Source: AKy350ZvBVWeDb51Bx4bNKnaXPWMG/yFIcAhYE3oEK8p96wFVj7BjYkimfkYIlJ4bR7TYEKBd/1G7g== X-Received: by 2002:a05:6870:65a9:b0:187:e1d0:ea03 with SMTP id fp41-20020a05687065a900b00187e1d0ea03mr2738394oab.11.1681744508255; Mon, 17 Apr 2023 08:15:08 -0700 (PDT) Received: from [192.168.0.15] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id n3-20020a056870034300b0017f84f81f3csm4604540oaf.52.2023.04.17.08.15.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 08:15:07 -0700 (PDT) Message-ID: Date: Mon, 17 Apr 2023 12:15:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230417143930.1186-1-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avutil/frame: use bitfields for some boolean and enum fields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/17/2023 12:00 PM, Lynne wrote: > Apr 17, 2023, 16:40 by jamrial@gmail.com: > >> Should reduce the size of AVFrame in the next major bump without changing the API. >> >> Suggested-by: Anton Khirnov >> Signed-off-by: James Almer >> --- >> This supersedes "avutil/frame: add new interlaced and top_field_first flags" >> and "avutil/frame: add a keyframe flag to AVFrame". >> >> libavutil/frame.h | 56 +++++++++++++++++++++++++++++++++++++++++++++ >> libavutil/version.h | 1 + >> 2 files changed, 57 insertions(+) >> >> diff --git a/libavutil/frame.h b/libavutil/frame.h >> index f85d630c5c..c26067f383 100644 >> --- a/libavutil/frame.h >> +++ b/libavutil/frame.h >> @@ -416,6 +416,7 @@ typedef struct AVFrame { >> */ >> int format; >> >> +#if FF_API_BITFIELDS >> /** >> * 1 -> keyframe, 0-> not >> */ >> @@ -425,6 +426,57 @@ typedef struct AVFrame { >> * Picture type of the frame. >> */ >> enum AVPictureType pict_type; >> +#else >> + /** >> + * 1 -> keyframe, 0-> not >> + */ >> + unsigned int key_frame: 1; >> + >> + /** >> + * The content of the picture is interlaced. >> + */ >> + unsigned int interlaced_frame: 1; >> + >> + /** >> + * If the content is interlaced, is top field displayed first. >> + */ >> + unsigned int top_field_first: 1; >> + >> + /** >> + * Tell user application that palette has changed from previous frame. >> + */ >> + unsigned int palette_has_changed: 1; >> + >> + /** >> + * Reserved. Must not be touched. >> + */ >> + unsigned int reserved_bitfield: (sizeof(unsigned int) * 8) - 9; >> + >> + /** >> + * MPEG vs JPEG YUV range. >> + * - encoding: Set by user >> + * - decoding: Set by libavcodec >> + */ >> + enum AVColorRange color_range: 2; >> + >> + enum AVChromaLocation chroma_location: 3; >> > > Definitely disagree on all non-8bit field limits. > The reserved_bitfield is especially ugly. > A few wasted bits wouldn't affect much, we don't even support building on 6502s. > Use bools, or limit them to 8bits so we can use bools when we bump? > The rest can be limited to 8bits. I added reserved_bitfield to turn what otherwise will be compiler-injected padding into something that can be reused if we were to add new fields here instead of at the end of the struct. I can remove it if you prefer, and make color_range and chroma_location into :8. Like i told you on IRC, i want to keep these as enum and not change their type to uint8_t, _Bool, or anything like that. Also, i wouldn't be surprised if using _Bool breaks some old weird compilers. With this change, I'm replacing 40 bytes worth of fields with 8 bytes worth of fields with no API break. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".