From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 19F934D0CC for ; Mon, 17 Feb 2025 09:37:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 97E2868BE44; Mon, 17 Feb 2025 11:37:23 +0200 (EET) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D58A468B4C3 for ; Mon, 17 Feb 2025 11:37:16 +0200 (EET) Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-30615661f98so41562771fa.2 for ; Mon, 17 Feb 2025 01:37:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1739785036; x=1740389836; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=52Vb95C5r7HMKSmuviCtchf3I5346Z69df2IKwrUFAo=; b=d61bJrndvy99J59fjHJSfPMtJWBpZf+U/6MEP+d+e5xZZBmuQ00p9yVH8gBCJKM/0U J5q5zlsMLvbRw/CSgI4wXiY+2E3MeXbc/uF37LlC0eWFBa202nyHIIpbFRITLsZBacZX FeM5CKc/o+NQhwREHGQucni2Sg3FIISyMRNJQ/jaDkg617rJkOrCFpQO+KYEAq+tkiCf m6nRqB6NRsnRjN/nZ979P/7HBdlNg5qphINHBr0J1lTGxqDtOEi5hmo8jw+OWrsnZ9Nl atiWefvxtBSkIg8Dud76WswEWSGennJ8PhfYCF7mxlWQ60gOgSoJ1Ih9cQ8zraYI7MNR UdeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739785036; x=1740389836; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=52Vb95C5r7HMKSmuviCtchf3I5346Z69df2IKwrUFAo=; b=c1KJb50NBnNM8xnI0arZsEhu29YgQxtds7jwIxIBeSYqk03rndpPYb01lIDpFAWQUp 5hyvu+O6/GgFPSnp/y9qCSRSC0eQnOahASThbp+KXy6wl6h54EiCuw/BsbXWNcy9vWQJ dbdgJx6JIcSPrA2BdfyXOSdeW9eY/y9AjfsNYqurqGM0Dap5brK9uYZn17rVBX2RvsHg D3SMPa47bf410prLd69C0rKUey43F3RuITCFyZV0tbxE3F+l7bTC1RZDvpTMbKd6C5Yg ve9ZvMIFhIHykSpRrfCRKFBmeSZEc/TjQhkgr8GiVAEd2fGUfbef4mXk3hXJUYSEVBvx 6/5g== X-Gm-Message-State: AOJu0YwFe6ploVI4AtEVjNEXa019wnfYP9T/Ugjt0M4WcyqES6WXvTZJ cXEBAFchCRJ6XA/xJ0LdQm3dYgzf5jeo15RSFSu6pVBZcmYAVxZCaLtImHRven5ZRmVQgYIqK8Y KXw== X-Gm-Gg: ASbGncs3Gu6FOkghQ+ZyClaRS9zZhWd01c4odDDf9VIUPVnXVY8Bw+6Leapci8K45hJ RoJjakzzui3cpN0gqGB2MldeDVAKogTRAWVRNAkcka9twNK+dIfZZd23/c97EjQ56fy20EGjGdL ebXwd/J4DfJANHMy5DthRbt9w6ll+tsbGYBb8l2uOK9fM4osFJp8krDm8Zv1Cg2Stgu+RYD2/zT cr7auohX4B438NUnezvAqAgZGH39vHN2hqLQI/qt0G6w9HwO8++DelnJvUNvNfSrzBJaYNtvMmk QIxGtlQ716ZkE6PwIBYg2820Xce/e3qB/9ch/6wX0pIiLAXN0gQa6xcDYJaiNquMm+MKPS7abQ7 wCvkcru3zn+4= X-Google-Smtp-Source: AGHT+IGnptZaXcm+HIp3/JMUr20zyRBklFGS0u165Mi2BSOLqKOkg4GB2vndnob89I3jsgokY/5laA== X-Received: by 2002:a2e:9bd9:0:b0:309:1f98:2848 with SMTP id 38308e7fff4ca-30927aa5220mr20386201fa.19.1739785035802; Mon, 17 Feb 2025 01:37:15 -0800 (PST) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-309100eaf3csm16291441fa.39.2025.02.17.01.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 01:37:15 -0800 (PST) Date: Mon, 17 Feb 2025 11:37:13 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Krzysztof Pyrkosz via ffmpeg-devel In-Reply-To: <3d9e1071-a7f4-c8c-4cae-bb3c64eb5fbb@martin.st> Message-ID: References: <20250211220642.116850-2-ffmpeg@szaka.eu> <3d9e1071-a7f4-c8c-4cae-bb3c64eb5fbb@martin.st> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/2] tests/checkasm/sw_rgb: Added {yuyv, uyvy}toyuv{420, 422} test cases X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Krzysztof Pyrkosz Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-15"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 17 Feb 2025, Martin Storsj=F6 wrote: > On Tue, 11 Feb 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote: > >> Splitting the previous patch into two. >> I noticed that on my x86 box, one of the newly added tests fail: >> = >> MMXEXT: >> uyvytoyuv420_mmxext (sw_rgb.c:126) >> yuyvtoyuv420_mmxext (sw_rgb.c:126) >> - sw_rgb.uyvytoyuv [FAILED] >> = >> SSE2, AVX and AVX2 are passing, though. > > I checked this, and the reason that this is failing, is that the chroma = > values are off by one, for a lot of the output pixels here. > > Kinda surprising for something that should only reshuffle pixels and not = > touch their values... Ah, right, this does average the chroma values when converting to 420. I = see that the NEON (which matches the C) doesn't do rounding, while I guess = the mmxext version does. Either we should tolerate an off-by-one (possibly = only if SWS_ACCURATE_RND or SWS_BITEXACT aren't set), change the mmxext = asm to round in the same way as the C code, or just drop the mmxext code. = (We don't seem to have this particular function implemented in any higher = x86 instruction set though.) // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".