From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EC17942ACD for ; Tue, 12 Apr 2022 23:09:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B5EF668B384; Wed, 13 Apr 2022 02:09:42 +0300 (EEST) Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1789568B350 for ; Wed, 13 Apr 2022 02:09:36 +0300 (EEST) Received: by mail-oi1-f178.google.com with SMTP id s1so313101oie.6 for ; Tue, 12 Apr 2022 16:09:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=w0KGndEiftA/IMAxId88B0aDXOyUtzfszeEjJcBiAP4=; b=IREXDMUmIigt6EeGExL4Cb/NjDWP1x75WgM7OHlZnxl1ED1G9qsetqz6+J1nhPu7L0 j+Ug+P4KAp1+RCeHjL2dWmKDREnOGI1jPEHnAWXeu9eR4LOBG+XBAqMwTBBSt/TZYdfU d6pLcitukPCXvbWW66j/HrDKxqr6ThSCFPteUME+pWmRsPZKYcy4acqsK4efgBATKii+ aK1cW0s3eohnL3cHmyDILhuORNzVfW1un32NeVLMoZlE8N8Y10VA7r4LL/nPZ1f7Ync1 aR++zhl+vXk6yRwvzLvzG6xfARfqQqgz3Hiu6Hi+tTXfy5yxwlAe2+wWiarJb65bi6hp xdCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=w0KGndEiftA/IMAxId88B0aDXOyUtzfszeEjJcBiAP4=; b=CfR/Ays3dJGU+yc629dCgqejJHStFVekCkwMWAsMdMpbjb5ZMYIF6Ud2Id3jZDRdPc H30+V8SslaBdTsNlKw7zuOAKN7ppQTB9NFa0OGXKEjLy3+5LTy0llj5VrEkMKlWw2Btw rqoFuv4BRQfjoB7K2P0x9Ouz/2q2RX3vgm0qIXdMsjKhIKDXozIuj5AK1kbz4MWVwQVd cXXfc1d4uE8zOIxfC56+esvNEAM8xGTkungh+8RSGKl5cs7gFTiO7maafm8waLea7OVe JeprSqzPNwsCfJ3SVNibutRnxhKwyK8VloeurnEcxURYrgJP3d1tAqXoSN6P7zIKQ7NK 4LDQ== X-Gm-Message-State: AOAM532tu/8j8167Db7a3lPtcK23xguqCutqkzaED6eoHXDSLfLSC1An RyE5Ph496XQ8lnXLzF9HfI3TdFIel3A= X-Google-Smtp-Source: ABdhPJx2uluI5s02uDO29vYudUeaLEQEMeKY7Wl4m3ZpjrZWZRG6T4topLsZmry+SIKUY84r4j20Ig== X-Received: by 2002:a05:6808:23d4:b0:2ec:f565:bc54 with SMTP id bq20-20020a05680823d400b002ecf565bc54mr2957287oib.185.1649804974160; Tue, 12 Apr 2022 16:09:34 -0700 (PDT) Received: from [192.168.0.12] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id r129-20020acac187000000b002ef358c6e0esm12936813oif.49.2022.04.12.16.09.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 16:09:33 -0700 (PDT) Message-ID: Date: Tue, 12 Apr 2022 20:09:31 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220406120056.10537-1-markg85@gmail.com> <20220406120056.10537-2-markg85@gmail.com> <20220410144127.GD2829255@pb2> <20220412180257.GL2829255@pb2> From: James Almer In-Reply-To: <20220412180257.GL2829255@pb2> Subject: Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/12/2022 3:02 PM, Michael Niedermayer wrote: > On Sun, Apr 10, 2022 at 04:41:27PM +0200, Michael Niedermayer wrote: >> On Wed, Apr 06, 2022 at 02:00:56PM +0200, Mark Gaiser wrote: >> [...] >> >>> + if (stat_ret < 0) { >> >>> + av_log(h, AV_LOG_INFO, "Unable to find IPFS folder. We tried:\n"); >>> + av_log(h, AV_LOG_INFO, "- $IPFS_PATH, which was empty.\n"); >>> + av_log(h, AV_LOG_INFO, "- $HOME/.ipfs (full uri: %s) which doesn't exist.\n", ipfs_full_data_folder); >> >> The 3 av_log() can also be combined >> >> If nothing else is found then ill change that myself and apply in a day or 2 > > applied > > thx This broke msvc > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): error C2065: 'PATH_MAX': undeclared identifier > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): error C2057: expected constant expression > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): error C2065: 'PATH_MAX': undeclared identifier > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): error C2057: expected constant expression > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): error C2466: cannot allocate an array of constant size 0 > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): error C2133: 'ipfs_full_data_folder': unknown size > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): error C2065: 'PATH_MAX': undeclared identifier > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): error C2057: expected constant expression > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): error C2466: cannot allocate an array of constant size 0 > C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): error C2133: 'ipfs_gateway_file': unknown size PATH_MAX seems to be POSIX only. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".