Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support.

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support.
Date: Tue, 12 Apr 2022 20:09:31 -0300
Message-ID: <faad6a72-22d4-6298-0f7c-49c7def68d05@gmail.com> (raw)
In-Reply-To: <20220412180257.GL2829255@pb2>

On 4/12/2022 3:02 PM, Michael Niedermayer wrote:
> On Sun, Apr 10, 2022 at 04:41:27PM +0200, Michael Niedermayer wrote:
>> On Wed, Apr 06, 2022 at 02:00:56PM +0200, Mark Gaiser wrote:
>> [...]
>>
>>> +        if (stat_ret < 0) {
>>
>>> +            av_log(h, AV_LOG_INFO, "Unable to find IPFS folder. We tried:\n");
>>> +            av_log(h, AV_LOG_INFO, "- $IPFS_PATH, which was empty.\n");
>>> +            av_log(h, AV_LOG_INFO, "- $HOME/.ipfs (full uri: %s) which doesn't exist.\n", ipfs_full_data_folder);
>>
>> The 3 av_log() can also be combined
>>
>> If nothing else is found then ill change that myself and apply in a day or 2
> 
> applied
> 
> thx

This broke msvc

> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): error C2065: 'PATH_MAX': undeclared identifier
> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(36): error C2057: expected constant expression
> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): error C2065: 'PATH_MAX': undeclared identifier
> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): error C2057: expected constant expression
> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): error C2466: cannot allocate an array of constant size 0
> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(46): error C2133: 'ipfs_full_data_folder': unknown size
> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): error C2065: 'PATH_MAX': undeclared identifier
> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): error C2057: expected constant expression
> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): error C2466: cannot allocate an array of constant size 0
> C:/Dev/ffmpeg/fate/x86_32-msvc-MD/src/libavformat/ipfsgateway.c(47): error C2133: 'ipfs_gateway_file': unknown size

PATH_MAX seems to be POSIX only.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".