From: Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne <dev@lynne.ee>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/diracdec: Mark flush as av_cold
Date: Tue, 28 May 2024 16:22:16 +0200
Message-ID: <fa28e308-c3cb-4aee-a389-37f6b3a36f0a@lynne.ee> (raw)
In-Reply-To: <AS8P250MB07442CD87F23271D3A63DCAC8FF12@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
[-- Attachment #1.1.1.1: Type: text/plain, Size: 1062 bytes --]
On 28/05/2024 16:03, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/diracdec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c
> index 5bf0dcc2db..76209aebba 100644
> --- a/libavcodec/diracdec.c
> +++ b/libavcodec/diracdec.c
> @@ -351,7 +351,7 @@ static int alloc_buffers(DiracContext *s, int stride)
> return 0;
> }
>
> -static void free_sequence_buffers(DiracContext *s)
> +static av_cold void free_sequence_buffers(DiracContext *s)
> {
> int i, j, k;
>
> @@ -413,7 +413,7 @@ static av_cold int dirac_decode_init(AVCodecContext *avctx)
> return 0;
> }
>
> -static void dirac_decode_flush(AVCodecContext *avctx)
> +static av_cold void dirac_decode_flush(AVCodecContext *avctx)
> {
> DiracContext *s = avctx->priv_data;
> free_sequence_buffers(s);
Both patches look good to me.
I'll remember to mark future decoders' flush with av_cold.
[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-28 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 14:00 [FFmpeg-devel] [PATCH 1/2] avcodec/diracdec: Use FF_CODEC_CAP_INIT_CLEANUP Andreas Rheinhardt
2024-05-28 14:03 ` [FFmpeg-devel] [PATCH 2/2] avcodec/diracdec: Mark flush as av_cold Andreas Rheinhardt
2024-05-28 14:22 ` Lynne via ffmpeg-devel [this message]
2024-05-30 18:54 ` [FFmpeg-devel] [PATCH 1/2] avcodec/diracdec: Use FF_CODEC_CAP_INIT_CLEANUP Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa28e308-c3cb-4aee-a389-37f6b3a36f0a@lynne.ee \
--to=ffmpeg-devel@ffmpeg.org \
--cc=dev@lynne.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git