From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C18E145C13 for ; Sat, 25 Mar 2023 19:43:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 455CE68CA6D; Sat, 25 Mar 2023 21:43:46 +0200 (EET) Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7255F68C7C0 for ; Sat, 25 Mar 2023 21:43:40 +0200 (EET) Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-17aa62d0a4aso5268648fac.4 for ; Sat, 25 Mar 2023 12:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679773418; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vOtgtAnS2hrdoRIac42tXqrJW6Pe7gLMG6fnW1R+vo0=; b=dOVqIcj0M3toEujTbxmiqQDVdBPu9Hkhyf7bab4B1EX8Aw9DLI5hC4C0qgGlJbyg6q u1JzkA+C2SV9R8BYVeys/iAFH+9Cnu4/Abhgtv7jclGEPO+XQkNvip+YqCC0RRTFZcOU 4JUqSBIflhmWCXUNb/fYSRZed9xajK6Xn4SXV/X4Q7/E8BcPCuVFip1Lqew9QdVE6hP+ siowT362UITD39FGrSDcy6zuLIScQ1HzqI/fzlnQKr0mAv5d5D/4vFVFd5i1YHre9GI1 Rwm1JSqTc7cQ8q/BUk67hHU7KKnp0LFrcag0L74vgV+K+IDQfSg+v+zLDq4oBZOgKXK2 Uj5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679773418; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vOtgtAnS2hrdoRIac42tXqrJW6Pe7gLMG6fnW1R+vo0=; b=YpwCt/zVbw6ypmyvpOLu0+nsNdWC2E4R52KGgNgNnxkginBUZ992K7RcuNwKRgiNG2 vl7/5QRxU+Gnqad4VT3cYvJM6a1QNpn5O6In7dbRXaQ6lVdIVnOAZxa0Kzv0shieEIY2 aP60K/8LAxEftq/5xxtqaTcL3B1IZoKbn3wZdRSwNxVaQiCphuXnHgFacH+h47svYljT 6ugzNiNEMFPkgUj9F0uo4HOXPDGHo8GtX6cc9zTAWMvtatEui3vHecilizWm3VHEHHP/ NktgRB+1GUk5Pr53O93PA7/yrK34k4AlDqIgge3Jbfk3Dw1/6QaZdHmp3h9KLGoEj8UX 8ZhQ== X-Gm-Message-State: AAQBX9dwx2c5BSR/6FXwecmDkvT5+F2zzutZO4WRlob/ymZ+BjF3gi0N U9ecEZazVbnYXcyofTAA08VfE2zb42Y= X-Google-Smtp-Source: AK7set/CtdHNQ/lobduP9AaN11WN/9MajRTCSEIIvXbvkFRJ5nTQGF1vaTrxZ71iAPS9x4EpL8nd1w== X-Received: by 2002:a05:6870:8287:b0:17a:a1fe:736b with SMTP id q7-20020a056870828700b0017aa1fe736bmr4589632oae.53.1679773418476; Sat, 25 Mar 2023 12:43:38 -0700 (PDT) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id ta10-20020a056871868a00b0017197629658sm8360053oab.56.2023.03.25.12.43.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Mar 2023 12:43:38 -0700 (PDT) Message-ID: Date: Sat, 25 Mar 2023 16:43:46 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230325191529.10578-1-anton@khirnov.net> <20230325191529.10578-9-anton@khirnov.net> From: James Almer In-Reply-To: <20230325191529.10578-9-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 09/23] fftools/ffmpeg: stop handling AVMEDIA_TYPE_DATA in init_output_stream_encode() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/25/2023 4:15 PM, Anton Khirnov wrote: > We do not support data encoders, so this should never be reached. nit: The abort() below could be an av_assert0(0) instead. It's the only abort() in the file, whereas av_assert0() is used a lot. > --- > fftools/ffmpeg.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index f00b2d44e4..a424c69725 100644 > --- a/fftools/ffmpeg.c > +++ b/fftools/ffmpeg.c > @@ -3174,8 +3174,6 @@ static int init_output_stream_encode(OutputStream *ost, AVFrame *frame) > } > } > > - break; > - case AVMEDIA_TYPE_DATA: > break; > default: > abort(); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".