From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EBC6B49C09 for ; Thu, 4 Apr 2024 13:01:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CB61E68D0B5; Thu, 4 Apr 2024 16:01:09 +0300 (EEST) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9C10768C90C for ; Thu, 4 Apr 2024 16:01:03 +0300 (EEST) Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-516bf5a145aso1156175e87.1 for ; Thu, 04 Apr 2024 06:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1712235663; x=1712840463; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=cUxsnHSI0OZbIlIhq4pl+ztfpjNgxlF15iJGfNfgnWk=; b=yD0J129HczjJeP4IwNh9P87K5hByyk5dTY+QKNoBo84w1fPFRijdktL5Ss51ZpYWsX 9R3e9Uf7OGtS5Gl4dd12P0CyQ1KwLEXIwWvfO9zgFOmtKsyJEe5Kjfai3iwlRfzYotqQ xNcjLZefWlH6ZGRbh8W+hMeHRjCkr0PCMbsCjqrSd8+dPRlfDrGk6XQh1FDXbLwzhp76 mJnHrSJU6DwcpHufaw40wQ6JjCLKrSmuCqUH2gdGNpGT2etlF0iEyPVsdD1sq60DkB21 rHQBzY1FNGttjkZoG0HkHXxPMYNgPAEPOyUpMn2T8mgPt9vfkruYtC2i7+0pSh5S6BMk ANdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712235663; x=1712840463; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cUxsnHSI0OZbIlIhq4pl+ztfpjNgxlF15iJGfNfgnWk=; b=G7V4UGoDyYDWX8o3KL9dC+yDM4O/byLgXxhuY5LpRXMMypy1hbfvkUoADfX8J67ru1 q6JDSw0OucnpPYCS1bDBgxXQnW7IYsd4LpymvqLi6Ohdkg0bmUrOxweclTXRHr8nFGLe LhtJpi76eJne77fgRKMpsxck4mKdJR9JKlF3SsRIohaiXfvKpzdlfC+OfAsiCRK+VIx4 amE77GzTwlnX7B1EWgs/AvsO7kjPjscVRLOULr/k8wk/+hcmRC33TI6gmlQs5yyeERG6 RdtTPSnVVJ5Ezc+kL7tVynTF5zdiW/2OblJ4TdJIC5yY7nQ9nBmgym1FB8gUItAd0S5l UU5A== X-Gm-Message-State: AOJu0YySLr+iOd1lI0NE890rTNgRWq+B6RZn6y8DHi5hucfHRnFLko3H Jksury6lKoQDQbKcceIAYyjqOeWM9NUFCoIAosD+ncUClQqcw9/i4UooAvqpe4YeUAV1A7h8ZAQ 71w== X-Google-Smtp-Source: AGHT+IFLgQ1/mB7kWMg5bkr6TfgG99zfv21urDE33n1VFMBkye013IiGRayV/YfLw/moNWwiE2/kdA== X-Received: by 2002:a05:6512:40d:b0:513:e17d:cf37 with SMTP id u13-20020a056512040d00b00513e17dcf37mr1703926lfk.19.1712235662694; Thu, 04 Apr 2024 06:01:02 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id y25-20020a197519000000b00513cfc2a7aesm2277935lfe.71.2024.04.04.06.01.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 06:01:02 -0700 (PDT) Date: Thu, 4 Apr 2024 16:01:01 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <18a55da1-45a2-43ee-b918-9eb67c5bf741@geoffhill.org> Message-ID: References: <18a55da1-45a2-43ee-b918-9eb67c5bf741@geoffhill.org> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v3 5/5] avcodec/ac3: Implement sum_square_butterfly_float for aarch64 NEON X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2 Apr 2024, Geoff Hill wrote: > Signed-off-by: Geoff Hill > --- > libavcodec/aarch64/ac3dsp_init_aarch64.c | 5 ++++ > libavcodec/aarch64/ac3dsp_neon.S | 35 ++++++++++++++++++++++++ > tests/checkasm/ac3dsp.c | 26 ++++++++++++++++++ > 3 files changed, 66 insertions(+) > > diff --git a/libavcodec/aarch64/ac3dsp_neon.S b/libavcodec/aarch64/ac3dsp_neon.S > index fa8fcf2e47..4a78ec0b2a 100644 > --- a/libavcodec/aarch64/ac3dsp_neon.S > +++ b/libavcodec/aarch64/ac3dsp_neon.S > @@ -88,3 +88,38 @@ function ff_ac3_sum_square_butterfly_int32_neon, export=1 > st1 {v0.1d-v3.1d}, [x0] > 1: ret > endfunc > + > +function ff_ac3_sum_square_butterfly_float_neon, export=1 > + cbz w3, 1f > + movi v0.4s, #0 > + movi v1.4s, #0 > + movi v2.4s, #0 > + movi v3.4s, #0 > +0: ld1 {v30.4s}, [x1], #16 > + ld1 {v31.4s}, [x2], #16 > + fadd v16.4s, v30.4s, v31.4s > + fsub v17.4s, v30.4s, v31.4s > + fmul v30.4s, v30.4s, v30.4s > + fadd v0.4s, v0.4s, v30.4s The arm version here used vmla instead of separate vmul+vadd - is there any reason why we can't use fmla here? // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".