From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 5/5] avcodec/ac3: Implement sum_square_butterfly_float for aarch64 NEON
Date: Thu, 4 Apr 2024 16:01:01 +0300 (EEST)
Message-ID: <f94b1b12-ed69-bed-3d6d-8ad77a6f9061@martin.st> (raw)
In-Reply-To: <18a55da1-45a2-43ee-b918-9eb67c5bf741@geoffhill.org>
On Tue, 2 Apr 2024, Geoff Hill wrote:
> Signed-off-by: Geoff Hill <geoff@geoffhill.org>
> ---
> libavcodec/aarch64/ac3dsp_init_aarch64.c | 5 ++++
> libavcodec/aarch64/ac3dsp_neon.S | 35 ++++++++++++++++++++++++
> tests/checkasm/ac3dsp.c | 26 ++++++++++++++++++
> 3 files changed, 66 insertions(+)
>
> diff --git a/libavcodec/aarch64/ac3dsp_neon.S b/libavcodec/aarch64/ac3dsp_neon.S
> index fa8fcf2e47..4a78ec0b2a 100644
> --- a/libavcodec/aarch64/ac3dsp_neon.S
> +++ b/libavcodec/aarch64/ac3dsp_neon.S
> @@ -88,3 +88,38 @@ function ff_ac3_sum_square_butterfly_int32_neon, export=1
> st1 {v0.1d-v3.1d}, [x0]
> 1: ret
> endfunc
> +
> +function ff_ac3_sum_square_butterfly_float_neon, export=1
> + cbz w3, 1f
> + movi v0.4s, #0
> + movi v1.4s, #0
> + movi v2.4s, #0
> + movi v3.4s, #0
> +0: ld1 {v30.4s}, [x1], #16
> + ld1 {v31.4s}, [x2], #16
> + fadd v16.4s, v30.4s, v31.4s
> + fsub v17.4s, v30.4s, v31.4s
> + fmul v30.4s, v30.4s, v30.4s
> + fadd v0.4s, v0.4s, v30.4s
The arm version here used vmla instead of separate vmul+vadd - is there
any reason why we can't use fmla here?
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-04-04 13:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 6:43 Geoff Hill
2024-04-04 13:01 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f94b1b12-ed69-bed-3d6d-8ad77a6f9061@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git