From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/5] lavu/common.h: Fix UB in av_clipl_int32_c()
Date: Thu, 30 May 2024 11:48:08 +0200
Message-ID: <f91925468bcb9c8c54e2a61d1b73f72f377c5f34.camel@haerdin.se> (raw)
In-Reply-To: <AS8P250MB0744366D92DB32B3531F99E98FF22@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
tor 2024-05-30 klockan 00:31 +0200 skrev Andreas Rheinhardt:
> Tomas Härdin:
> > */
> > static av_always_inline av_const int32_t av_clipl_int32_c(int64_t
> > a)
> > {
> > - if ((a+0x80000000u) & ~UINT64_C(0xFFFFFFFF)) return
> > (int32_t)((a>>63) ^ 0x7FFFFFFF);
> > - else return
> > (int32_t)a;
> > + if ((a+UINT64_C(0x80000000)) & ~UINT64_C(0xFFFFFFFF)) return
> > (int32_t)((a>>63) ^ 0x7FFFFFFF);
> > + else return
> > (int32_t)a;
>
> IMO (uint64_t)a + 0x80000000 is more readable. (Maybe it would even
> be
> good to use >> 32 instead of ~UINT64_C(0xFFFFFFFF)?)
It already uses UINT64_C, hence why I used it.
>> 32 would work also. Does it make any difference performance wise?
/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-30 9:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 22:13 Tomas Härdin
2024-05-29 22:13 ` [FFmpeg-devel] [PATCH 2/5] lavu/common.h: Fix UB in av_clip_intp2_c() Tomas Härdin
2024-05-29 22:24 ` Andreas Rheinhardt
2024-05-29 23:08 ` Tomas Härdin
2024-05-29 22:14 ` [FFmpeg-devel] [PATCH 3/5] lavu/common.h: Fix UB in av_clip_uintp2_c() Tomas Härdin
2024-05-31 0:27 ` Michael Niedermayer
2024-05-29 22:14 ` [FFmpeg-devel] [PATCH 4/5] lavu/intmath.h: Fix UB in ff_ctz_c() and ff_ctzll_c() Tomas Härdin
2024-05-30 7:54 ` Rémi Denis-Courmont
2024-05-30 9:50 ` Tomas Härdin
2024-05-30 12:29 ` Hendrik Leppkes
2024-05-30 13:06 ` Rémi Denis-Courmont
2024-05-30 14:03 ` Tomas Härdin
2024-05-30 14:32 ` Rémi Denis-Courmont
2024-05-31 0:43 ` Ronald S. Bultje
2024-05-31 0:41 ` Michael Niedermayer
2024-05-31 5:48 ` Rémi Denis-Courmont
2024-05-31 0:31 ` Michael Niedermayer
2024-05-29 22:15 ` [FFmpeg-devel] [PATCH 5/5] lavu/mathematics: Return early if either a or b is zero Tomas Härdin
2024-05-31 0:22 ` Michael Niedermayer
2024-05-31 15:21 ` Tomas Härdin
2024-05-29 22:31 ` [FFmpeg-devel] [PATCH 1/5] lavu/common.h: Fix UB in av_clipl_int32_c() Andreas Rheinhardt
2024-05-30 9:48 ` Tomas Härdin [this message]
2024-05-30 6:41 ` Rémi Denis-Courmont
2024-05-30 9:40 ` Tomas Härdin
2024-05-30 11:50 ` Rémi Denis-Courmont
2024-05-30 14:07 ` Tomas Härdin
2024-05-30 14:28 ` Rémi Denis-Courmont
2024-05-30 15:32 ` Tomas Härdin
2024-05-30 15:38 ` Rémi Denis-Courmont
2024-05-31 1:03 ` Michael Niedermayer
2024-06-03 7:32 ` Rémi Denis-Courmont
2024-06-03 21:21 ` Michael Niedermayer
2024-05-30 15:42 ` James Almer
2024-05-30 16:48 ` Tomas Härdin
2024-05-30 17:49 ` Rémi Denis-Courmont
2024-05-30 19:07 ` Michael Niedermayer
2024-05-30 19:20 ` Rémi Denis-Courmont
2024-05-31 15:23 ` Tomas Härdin
2024-06-14 12:31 ` Tomas Härdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f91925468bcb9c8c54e2a61d1b73f72f377c5f34.camel@haerdin.se \
--to=git@haerdin.se \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git