Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] avformat/movenc: Remove experimental status of TrueHD-in-MP4 muxing (mlpa)
@ 2022-11-05 21:31 Nomis101
  2022-11-06 21:40 ` Nomis101
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Nomis101 @ 2022-11-05 21:31 UTC (permalink / raw)
  To: ffmpeg-devel

Support for mlpa muxing was added back in 2019: 
http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=808a6717e0c584738c60a109afd6d47f4973d619
But it was hidden back then behind FF_COMPLIANCE_EXPERIMENTAL, because it was new and there was no 
support from other applications.

In the meantime there is support in MediaInfo: MediaArea/MediaInfoLib#1258

For VLC: videolan/vlc@9c49f40

Since version 7.3.4 for Infuse: https://community.firecore.com/t/dolby-mlp-mlpa-codec-support/26100/31
And mpv does support this as well.
So, there is no need anymore to hide this behind FF_COMPLIANCE_EXPERIMENTAL. Also, it should be the 
user's responsibility to choose this only if the user's software/hardware supports it.
Therefore, this patch removes the experimental status of TrueHD-in-MP4 muxing.

Signed-off-by: Nomis101 <Nomis101@web.de>
---
  libavformat/movenc.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 754f95912a..50f1831860 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -7157,7 +7157,6 @@ static int mov_init(AVFormatContext *s)
                  }
              }
              if (track->par->codec_id == AV_CODEC_ID_FLAC ||
-                track->par->codec_id == AV_CODEC_ID_TRUEHD ||
                  track->par->codec_id == AV_CODEC_ID_OPUS) {
                  if (track->mode != MODE_MP4) {
                      av_log(s, AV_LOG_ERROR, "%s only supported in MP4.\n", 
avcodec_get_name(track->par->codec_id));
-- 
2.37.1 (Apple Git-137.1)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-11-11 16:16 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-05 21:31 [FFmpeg-devel] [PATCH] avformat/movenc: Remove experimental status of TrueHD-in-MP4 muxing (mlpa) Nomis101
2022-11-06 21:40 ` Nomis101
2022-11-06 21:44   ` James Almer
2022-11-06 21:48 ` James Almer
2022-11-06 21:57 ` Carl Eugen Hoyos
2022-11-09 19:15   ` Nomis101
2022-11-11 14:05     ` Jan Ekström
2022-11-11 14:48       ` Nomis101
2022-11-11 15:05         ` Nomis101
2022-11-11 16:16           ` Gijs Peskens

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git