From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v4 1/2] avcodec/avutil: move dynamic HDR10+ metadata parsing to libavutil
Date: Mon, 13 Mar 2023 17:38:00 -0300
Message-ID: <f8f9a56f-b17e-78d1-cdec-7a63e63d786b@gmail.com> (raw)
In-Reply-To: <bab7f245-2b00-79d6-f2c2-df5bc3e0d98c@vimeo.com>
On 3/13/2023 5:22 PM, Raphaël Zumer wrote:
> Signed-off-by: Raphaël Zumer <rzumer@tebako.net>
> ---
> libavcodec/Makefile | 2 +-
> libavcodec/dynamic_hdr10_plus.c | 198 -------------------------------
> libavcodec/dynamic_hdr10_plus.h | 35 ------
> libavcodec/h2645_sei.c | 6 +-
> libavutil/hdr_dynamic_metadata.c | 180 ++++++++++++++++++++++++++++
> libavutil/hdr_dynamic_metadata.h | 11 ++
> 6 files changed, 195 insertions(+), 237 deletions(-)
> delete mode 100644 libavcodec/dynamic_hdr10_plus.c
> delete mode 100644 libavcodec/dynamic_hdr10_plus.h
This is missing the required changes in the av1 and libdav1d decoders
like you did for h2645_sei. Support in them is pretty recent, so i
assume your tree is slightly outdated? Otherwise compilation should have
failed for you.
I can make the changes before pushing since it's a one line change for
each decoder, so no need for a new version.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-03-13 20:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 20:22 Raphaël Zumer
2023-03-13 20:38 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8f9a56f-b17e-78d1-cdec-7a63e63d786b@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git