From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: use an int for nb_threads
Date: Sat, 15 Feb 2025 12:26:43 -0300
Message-ID: <f8b48811-01cf-48b1-9da1-b8db8154a1f2@gmail.com> (raw)
In-Reply-To: <96d58c24-556c-465a-9325-dc6f3e6deaaa@gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 566 bytes --]
On 2/15/2025 12:42 AM, James Almer wrote:
> On 2/14/2025 10:28 PM, Andreas Rheinhardt wrote:
>>
>> What about "auto"? I thought that was a thing. Or do I misremember?
>
> Ah, you're right that's an alias for 0.
> I guess i could use av_opt_eval_int(), but maybe it's not worth the hassle.
Actually, it's fine as is. The value for "threads" was parsed before
this code. In here, we're using the value as stored in enc_ctx by
av_opt_set_dict2() in ost_add(), so "auto" was already interpreted as 0.
I'll push this soon unless there are objections.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-02-15 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 16:33 James Almer
2025-02-15 1:28 ` Andreas Rheinhardt
2025-02-15 3:42 ` James Almer
2025-02-15 15:26 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8b48811-01cf-48b1-9da1-b8db8154a1f2@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git