From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D755B41D27 for ; Sun, 20 Mar 2022 17:03:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BA1AF68A64A; Sun, 20 Mar 2022 19:03:19 +0200 (EET) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DD07768A64A for ; Sun, 20 Mar 2022 19:03:12 +0200 (EET) Received: by mail-ot1-f48.google.com with SMTP id e25-20020a0568301e5900b005b236d5d74fso9153244otj.0 for ; Sun, 20 Mar 2022 10:03:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=MWX+i3zbyXAaxDIJhheC07yf+XD0sNTYLP1LvZnszf8=; b=p2prMJzJgKL6HuDQQ4D7R+UUqI6Xu/UOZdKLlmTsR4++MTdZ5DFtHaBPwjVjfyaIsa PzrBmkH8paZyGA9q1fZPnGZIdvNtnMOMNEbQp4m8CIfud9o+CqZuAyNoI0diiYUdoEMk c6zOSZdiQGmablJORkFuYvMdwrRpK7aHCP222MiP/b7dQBw+fG+moAdvO0dch9VJuucQ L3ZdVtkKG3x+Lt+F0dX7CUEjQ2OTcIGWyiy/TXdg9mDDBlfTIPUlE1moJqZS+0NpK0fd U6QuCfIv3XrP5wjUwuDQ4Jwz4IoULZJXKBCzgclDgV5qKPLxALqg7H09zN1988gYVOM9 1yvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=MWX+i3zbyXAaxDIJhheC07yf+XD0sNTYLP1LvZnszf8=; b=s1Ekrx6KTrguT14d8jjrcTQyf/M6PlB1BZJqCvn2iJJqLYnODUkg/2Qr+0l/7wtN9n M3n0sR4rKAl2s34cj6wwUSErIOkUjQjYBy+9UgxbZX4coPS2UfmhKjJ81o8TdQ7hoXv9 tjpv708RVIjLU+IXN9kVTuTGsbhfJpTbG4rMPVAA0UbCdUhiI2L72UQlMkFBRrWdm59C QKEMmh9V2EexW6YnGATw6kndAfuwnAiwS7qosYmeniOvmzZ80+iKBTKF/JQnrl4+Of8k vuje4EEGo1cJ4af9tdOV3GotXVE5LOVKAwTcMEOloKV50y502+ft4gAxac8oJVjoHh4y mx3Q== X-Gm-Message-State: AOAM5322SOkNQvLiZ6wM9zh3Nubfe8cPfamwXZukMKvngG8t0z9bAd0o xdOVcU0AodXjTchpbnLXMqC9cho24PwtIA== X-Google-Smtp-Source: ABdhPJweowT+Dfmz2/elZjh/CHtYv+i5i1RE3KcjwQ2oNErW9CSmo/fd2n1aIOcTq0Q0myTEWPpqXg== X-Received: by 2002:a05:6830:1dfd:b0:5b2:2b98:1d8d with SMTP id b29-20020a0568301dfd00b005b22b981d8dmr6405766otj.20.1647795789458; Sun, 20 Mar 2022 10:03:09 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id 37-20020a9d0328000000b005b2265711fcsm6299839otv.16.2022.03.20.10.03.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Mar 2022 10:03:08 -0700 (PDT) Message-ID: Date: Sun, 20 Mar 2022 14:03:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220319030407.45503-1-jamrial@gmail.com> <164769762003.19727.8418628331219276771@lain.red.khirnov.net> From: James Almer In-Reply-To: <164769762003.19727.8418628331219276771@lain.red.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/19/2022 10:47 AM, Anton Khirnov wrote: > Quoting James Almer (2022-03-19 04:04:07) >> The function is not meant to clear codec parameters, and the lavf demux code >> relies on this behavior. > > Maybe it shouldn't? > > Which code is it exactly? The parser included by demux.c. That file calls avcodec_close() in certain situations, but the avctx is still used when calling av_parser_parse2() as it's expected that all the parameters are left intact, and all were until 327efa6633, where avctx->ch_layout started being uninitialized, and it shouldn't. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".