From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't uninitialize ch_layout in avcodec_close()
Date: Sun, 20 Mar 2022 14:03:08 -0300
Message-ID: <f8979c35-e2db-86de-5aad-5ada2274e11f@gmail.com> (raw)
In-Reply-To: <164769762003.19727.8418628331219276771@lain.red.khirnov.net>
On 3/19/2022 10:47 AM, Anton Khirnov wrote:
> Quoting James Almer (2022-03-19 04:04:07)
>> The function is not meant to clear codec parameters, and the lavf demux code
>> relies on this behavior.
>
> Maybe it shouldn't?
>
> Which code is it exactly?
The parser included by demux.c. That file calls avcodec_close() in
certain situations, but the avctx is still used when calling
av_parser_parse2() as it's expected that all the parameters are left
intact, and all were until 327efa6633, where avctx->ch_layout started
being uninitialized, and it shouldn't.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-03-20 17:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 3:04 James Almer
2022-03-19 7:50 ` Hendrik Leppkes
2022-03-20 18:51 ` James Almer
2022-03-20 22:01 ` Hendrik Leppkes
2022-03-20 22:12 ` James Almer
2022-03-20 22:34 ` Marton Balint
2022-03-20 22:52 ` James Almer
2022-03-20 23:09 ` Marton Balint
2022-03-19 13:47 ` Anton Khirnov
2022-03-20 17:03 ` James Almer [this message]
2022-03-20 19:06 ` James Almer
2022-03-20 23:38 ` Andreas Rheinhardt
2022-03-21 7:37 ` Hendrik Leppkes
2022-03-21 7:51 ` Anton Khirnov
2022-03-21 12:10 ` James Almer
2022-03-21 21:08 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8979c35-e2db-86de-5aad-5ada2274e11f@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git