From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 698DD48485 for ; Tue, 5 Dec 2023 11:47:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4D6F868C9D8; Tue, 5 Dec 2023 13:47:20 +0200 (EET) Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6455468C482 for ; Tue, 5 Dec 2023 13:47:14 +0200 (EET) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 52DD42C1E26 for ; Tue, 5 Dec 2023 12:47:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1701776833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wT29rTRHatdk49AXHt2BWQzh7b8BehwgHpEBg8jCZNk=; b=Bqxwx2yEgDdVz67miDNDkNp8+xjVLf4KeesscwtfAluP+araBVsrOkNbhJ6DCzQEO6P0vB GtR0SfGSuVXNcNIZQ7Ql9OFMBFoLV4zjhnIoxT2Pvh1mFize1Yxrfz5DD2/QjUhiR421l0 lufo4oX3ceraJT8b4pB0sG7J4cBjF/ZXjNv9/4jTsvxfmEYpxDd0n8LYblKNcHIBduVusV 0wZNJJa8//w4CW9zqUgcRlXR475uRfmWG1GX/5ltBZK7V1osig14r/tDGXTnakHM7v6UAs lAysFq4jmYiJGapRXm0Imoc6XJcPdmKgej1KCX6PoONhZwFdxKT03QSjpmp56A== Message-ID: Date: Tue, 5 Dec 2023 12:47:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231205081511.2794166-1-haihao.xiang@intel.com> Content-Language: en-US From: Timo Rothenpieler In-Reply-To: <20231205081511.2794166-1-haihao.xiang@intel.com> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: Set default bitrate to 2M X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 05.12.2023 09:15, Xiang, Haihao wrote: > From: Haihao Xiang > > 2M is suitable for more cases, e.g. 4K video. > > Signed-off-by: Haihao Xiang > --- > libavcodec/qsvenc_av1.c | 2 +- > libavcodec/qsvenc_h264.c | 2 +- > libavcodec/qsvenc_hevc.c | 2 +- > libavcodec/qsvenc_mpeg2.c | 2 +- > libavcodec/qsvenc_vp9.c | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/qsvenc_av1.c b/libavcodec/qsvenc_av1.c > index c697845d7b..78c92c1844 100644 > --- a/libavcodec/qsvenc_av1.c > +++ b/libavcodec/qsvenc_av1.c > @@ -129,7 +129,7 @@ static const AVClass class = { > }; > > static const FFCodecDefault qsv_enc_defaults[] = { > - { "b", "1M" }, > + { "b", "2M" }, Wouldn't it be better to use a constant quality option as default, rather than a fixed bitrate? 2M still seems incredibly low for 1080p, let alone for 4K content. > { "g", "-1" }, > { "bf", "-1" }, > { "refs", "0" }, > diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c > index 071a9a79e9..37b39cb441 100644 > --- a/libavcodec/qsvenc_h264.c > +++ b/libavcodec/qsvenc_h264.c > @@ -178,7 +178,7 @@ static const AVClass class = { > }; > > static const FFCodecDefault qsv_enc_defaults[] = { > - { "b", "1M" }, > + { "b", "2M" }, > { "refs", "0" }, > { "g", "-1" }, > { "bf", "-1" }, > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > index c5b7ac7cc4..181d06cb00 100644 > --- a/libavcodec/qsvenc_hevc.c > +++ b/libavcodec/qsvenc_hevc.c > @@ -374,7 +374,7 @@ static const AVClass class = { > }; > > static const FFCodecDefault qsv_enc_defaults[] = { > - { "b", "1M" }, > + { "b", "2M" }, > { "refs", "0" }, > { "g", "248" }, > { "bf", "-1" }, > diff --git a/libavcodec/qsvenc_mpeg2.c b/libavcodec/qsvenc_mpeg2.c > index 22f1ff7c0d..012cec3a58 100644 > --- a/libavcodec/qsvenc_mpeg2.c > +++ b/libavcodec/qsvenc_mpeg2.c > @@ -82,7 +82,7 @@ static const AVClass class = { > }; > > static const FFCodecDefault qsv_enc_defaults[] = { > - { "b", "1M" }, > + { "b", "2M" }, > { "refs", "0" }, > // same as the x264 default > { "g", "250" }, > diff --git a/libavcodec/qsvenc_vp9.c b/libavcodec/qsvenc_vp9.c > index d0340ef94b..8658b8ec2d 100644 > --- a/libavcodec/qsvenc_vp9.c > +++ b/libavcodec/qsvenc_vp9.c > @@ -93,7 +93,7 @@ static const AVClass class = { > }; > > static const FFCodecDefault qsv_enc_defaults[] = { > - { "b", "1M" }, > + { "b", "2M" }, > { "refs", "0" }, > { "g", "250" }, > { "trellis", "-1" }, _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".