From: James Almer <jamrial@gmail.com>
To: Wu Jianhua <toqsxw@outlook.com>,
"ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] 回复: [PATCH 2/2] avformat/mov: improve HEIF parsing
Date: Sat, 13 Apr 2024 10:12:34 -0300
Message-ID: <f87811fc-311b-4a9e-862a-128cac0a588d@gmail.com> (raw)
In-Reply-To: <TYWP286MB2172EE3B50011EBC85879F48CA0B2@TYWP286MB2172.JPNP286.PROD.OUTLOOK.COM>
On 4/13/2024 8:04 AM, Wu Jianhua wrote:
>> 发件人: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> 代表 James Almer <jamrial@gmail.com>
>> 发送时间: 2024年1月9日 11:55
>> 收件人: ffmpeg-devel@ffmpeg.org
>> 主题: [FFmpeg-devel] [PATCH 2/2] avformat/mov: improve HEIF parsing
>>
>> Parse iinf boxes and its child infe boxes to get the actual codec used
>> (AV1 for avif, HEVC for heic), and properly export extradata in a generic
>> way.
>>
>> The avif tests reference files are updated as the extradata is now exported.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>> libavformat/isom.h | 3 +-
>> libavformat/mov.c | 157 ++++++++++--------
>> .../fate/mov-avif-demux-still-image-1-item | 2 +-
>> .../mov-avif-demux-still-image-multiple-items | 2 +-
>> 4 files changed, 95 insertions(+), 69 deletions(-)
>>
>
>> + if (version != 2) {
>> + av_log(c->fc, AV_LOG_ERROR, "infe: version != 2 not supported.\n");
>> + return AVERROR_PATCHWELCOME;
>> + }
>> +
>
> Hi James,
>
> With the change, some errors occurred and the current FFmpeg failed to decode a lot of videos that can be decoded by older FFmpeg.
> [mov,mp4,m4a,3gp,3g2,mj2 @ 000001e6e79aac80] st: 0 edit list: 1 Missing key frame while searching for timestamp: 1000
> [mov,mp4,m4a,3gp,3g2,mj2 @ 000001e6e79aac80] st: 0 edit list 1 Cannot find an index entry before timestamp: 1000.
> [mov,mp4,m4a,3gp,3g2,mj2 @ 000001e6e79aac80] infe: version < 2 not supported
> [mov,mp4,m4a,3gp,3g2,mj2 @ 000001e6e79aac80] error reading header
>
> I'm not familiar with the mov. Is it possible to treat this error as a warning and skip it when the version < 2?
>
> Thanks,
> Jianhua
Can you test
https://ffmpeg.org//pipermail/ffmpeg-devel/2024-April/325644.html ?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-04-13 13:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 19:55 [FFmpeg-devel] [PATCH 1/2] avformat/mov: rename avif fields to heif James Almer
2024-01-09 19:55 ` [FFmpeg-devel] [PATCH 2/2] avformat/mov: improve HEIF parsing James Almer
2024-01-10 1:27 ` [FFmpeg-devel] [PATCH 2/2 v2] " James Almer
2024-01-15 16:50 ` James Almer
2024-04-13 11:04 ` [FFmpeg-devel] 回复: [PATCH 2/2] " Wu Jianhua
2024-04-13 13:12 ` James Almer [this message]
2024-04-13 14:20 ` [FFmpeg-devel] 回复: " Wu Jianhua
2024-01-10 21:06 ` [FFmpeg-devel] [PATCH 1/2] avformat/mov: rename avif fields to heif Vignesh Venkat via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f87811fc-311b-4a9e-862a-128cac0a588d@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=toqsxw@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git