From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 46EEE44CFD for ; Mon, 19 Dec 2022 02:36:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AD25C68BA08; Mon, 19 Dec 2022 04:36:03 +0200 (EET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C51F468019F for ; Mon, 19 Dec 2022 04:35:56 +0200 (EET) Received: from kwepemi100013.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Nb3h82FYlzmWjS for ; Mon, 19 Dec 2022 10:34:48 +0800 (CST) Received: from kwepemi500014.china.huawei.com (7.221.188.232) by kwepemi100013.china.huawei.com (7.221.188.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 19 Dec 2022 10:35:53 +0800 Received: from kwepemi500014.china.huawei.com ([7.221.188.232]) by kwepemi500014.china.huawei.com ([7.221.188.232]) with mapi id 15.01.2375.034; Mon, 19 Dec 2022 10:35:53 +0800 From: "Wujian(Chin)" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -safe to replace the user name and password in the protocol address Thread-Index: AdkR6kCaPiIZsC5wR7GatfIhHllSDQAT8N6AAEW6eHA= Date: Mon, 19 Dec 2022 02:35:53 +0000 Message-ID: References: <1f01a2a041ba4e809ec8d9175fde8d8e@huawei.com> <0bc70706-31f3-9807-aebf-ccf648261c06@rothenpieler.org> In-Reply-To: <0bc70706-31f3-9807-aebf-ccf648261c06@rothenpieler.org> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.136.102.143] MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: [FFmpeg-devel] =?gb2312?b?tPC4tDogIFtQQVRDSF0gZmZ0b29scy9mZm1w?= =?gb2312?b?ZWdfZmZwbGF5X2ZmcHJvYmVfY21kdXRpbHM6IGFkZCAtc2FmZSB0byByZXBs?= =?gb2312?b?YWNlIHRoZSB1c2VyIG5hbWUgYW5kIHBhc3N3b3JkIGluIHRoZSBwcm90b2Nv?= =?gb2312?b?bCBhZGRyZXNz?= X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On 17.12.2022 08:36, Wujian(Chin) wrote: > > The Protocol address may contain the user name and password. The ps -ef command may expose the plaintext. > > The -safe parameter option is added to replace the user name and password in the command line with the asterisk (*). > > > > Signed-off-by: wujian_nanjing > > --- > > doc/ffmpeg.texi | 7 +++++++ > > doc/ffplay.texi | 8 ++++++++ > > doc/ffprobe.texi | 7 +++++++ > > fftools/cmdutils.c | 47 +++++++++++++++++++++++++++++++++++++++++++---- > > fftools/cmdutils.h | 15 +++++++++++++++ > > fftools/ffmpeg.c | 16 +++++++++++++--- > > fftools/ffplay.c | 15 +++++++++++++-- > > fftools/ffprobe.c | 18 ++++++++++++++---- > > 8 files changed, 120 insertions(+), 13 deletions(-) > > > > diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 0367930..e905542 > > 100644 > > --- a/doc/ffmpeg.texi > > +++ b/doc/ffmpeg.texi > > @@ -50,6 +50,13 @@ output files. Also do not mix options which belong to different files. All > > options apply ONLY to the next input or output file and are reset between files. > > > > @itemize > > +@item -safe > > +The Protocol address may contain the user name and password. The ps -ef command may expose the plaintext. > > +The -safe parameter option is added to replace the user name and password in the command line with the asterisk (*). > > +@example > > +ffmpeg -safe -i rtsp://username@password.xxxx.com @end example > > + > > @item > > To set the video bitrate of the output file to 64 kbit/s: > > @example > > diff --git a/doc/ffplay.texi b/doc/ffplay.texi index 5dd860b..f46ca91 > > 100644 > > --- a/doc/ffplay.texi > > +++ b/doc/ffplay.texi > > @@ -122,6 +122,14 @@ Read @var{input_url}. > > > > @section Advanced options > > @table @option > > + > > +@item -safe > > +The Protocol address may contain the user name and password. The ps -ef command may expose the plaintext. > > +The -safe parameter option is added to replace the user name and password in the command line with the asterisk (*). > > +@example > > +ffplay -safe -i rtsp://username@password.xxxx.com @end example > > + > > @item -stats > > Print several playback statistics, in particular show the stream > > duration, the codec parameters, the current position in the stream > > and diff --git a/doc/ffprobe.texi b/doc/ffprobe.texi index > > 4dc9f57..92b13cf 100644 > > --- a/doc/ffprobe.texi > > +++ b/doc/ffprobe.texi > > @@ -89,6 +89,13 @@ Set the output printing format. > > @var{writer_name} specifies the name of the writer, and > > @var{writer_options} specifies the options to be passed to the writer. > > > > +@item -safe > > +The Protocol address may contain the user name and password. The ps -ef command may expose the plaintext. > > +The -safe parameter option is added to replace the user name and password in the command line with the asterisk (*). > > +@example > > +ffprobe -safe -i rtsp://username@password.xxxx.com @end example > > + > > For example for printing the output in JSON format, specify: > > @example > > -print_format json > > diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index > > a1de621..22407f8 100644 > > --- a/fftools/cmdutils.c > > +++ b/fftools/cmdutils.c > > @@ -61,6 +61,40 @@ AVDictionary *format_opts, *codec_opts; > > > > int hide_banner = 0; > > > > +void param_masking(int argc, char **argv) { > > + int i, j; > > + for (i = 1; i < argc; i++) { > > + char *match = strstr(argv[i], "://"); > > + if (match) { > > + int total = strlen(argv[i]); > > + for (j = 0; j < total; j++) { > > + argv[i][j] = '*'; > > + } > > + } > > + } > > +} > Won't that replace the entire parameter, as in, the full URL, with ***? > While the documentation claims only the username/password will be replaced. The description is incorrect. The URL of the user name and password should be replaced. I will modify it later. Thank you for your question . _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".