From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0984047DB7 for ; Wed, 27 Dec 2023 13:44:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3BE8E68CA21; Wed, 27 Dec 2023 15:44:18 +0200 (EET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F210468C89E for ; Wed, 27 Dec 2023 15:44:11 +0200 (EET) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-40d5d8a6730so5889775e9.1 for ; Wed, 27 Dec 2023 05:44:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703684650; x=1704289450; darn=ffmpeg.org; h=content-transfer-encoding:content-language:to:subject:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=uBz9v7afPKzDFeFaKJaKKbIG29HQL8PYj+X4JYbT93A=; b=hCfv8eS+iC98jHNqBSLEMUh2QWWpK8pAED2u4O5qAazMGRN7yUW3faV5fz3iu4DTB6 AzJ9/TqrEtOB92/P8qEr/qeD1JyemcX819/C4IepXTT+izcY7LiRXnta71nnE5UM+KQX H9/aQ26BUpqN78G6RyTEXRHuu/IYRybx0fmr9f+Ja4a0pFzgykzBXjnQnyW0PfggPQB7 2lRrXT1V2ge8HZN4DYkSz3dnoYxOTQfaapOIBzrkVxPuCZttyf3kiYsJ9QjKWuOy7b6H E4j7vRpCp/0YpQ0IOtaUlyJfQkUL6ALwCc5yF0h4x0oJY+0mo1W2dKtLIFmO/QTUYtsr XMjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703684650; x=1704289450; h=content-transfer-encoding:content-language:to:subject:from :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uBz9v7afPKzDFeFaKJaKKbIG29HQL8PYj+X4JYbT93A=; b=tMvbsijdCC73s5+mFFKd9xktl961M21tBOjE4zphxqRub3o3/OcKjwEx6hXxtxnhHC ks2hGC9fT9MzueXadlL75znMdUFrB6ts6sAiabVWfHMaQoiI0pJVcXewlOeuYLbmdUlH jKACvYGgcfq43P2rUVID+wJGmEVIaEAAQjM5GB3JYZawQFjHtwtJZ/hOvMdZCYdRp7lv F+ToN9bgnGrgY8txl0htMhxg7tr1amFdyiwxqP3uLAiyKK6CGqqthvFa22h4urz13EZE CsRTn96kE3BPFr3g0O8t3b0zlsx0ScxxHokmgcVFvPfwaCIrWu8JIyPwpx/0EErYRezO JXfw== X-Gm-Message-State: AOJu0YyQnL6mRD0bL3le3A9lFEUw+wsPMEFL/BgsBt/dy1QJ7pYuNVeE SXumFUUXjV0wBb32At+CUosBBmGVHN8= X-Google-Smtp-Source: AGHT+IGuxnES2R7+i+lS5PWBYr54MDIexJxBgfxiENpMGw6vrt8LT2zzuJI4JRRi6ZlhJvPpU8CRrQ== X-Received: by 2002:a05:600c:1709:b0:40d:3d98:3747 with SMTP id c9-20020a05600c170900b0040d3d983747mr4878937wmn.121.1703684650395; Wed, 27 Dec 2023 05:44:10 -0800 (PST) Received: from [192.168.2.77] ([93.183.214.73]) by smtp.gmail.com with ESMTPSA id iv13-20020a05600c548d00b0040d30af488asm29001703wmb.40.2023.12.27.05.44.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Dec 2023 05:44:10 -0800 (PST) Message-ID: Date: Wed, 27 Dec 2023 15:44:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Paul Orlyk To: ffmpeg-devel@ffmpeg.org Content-Language: en-US Subject: [FFmpeg-devel] [PATCH] avformat/rtsp: Fix server compatibility issues with rtspclientsink GStreamer plugin X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: mode field in Transport header can be sent in upper case so make string comparison case insensitive. Also, GStreamer expects to see mode=record instead of mode=receive in Transport header in response. Signed-off-by: Paul Orlyk --- libavformat/rtsp.c | 4 ++-- libavformat/rtspdec.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 583f5338e8..61e24a5c7a 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1012,8 +1012,8 @@ static void rtsp_parse_transport(AVFormatContext *s, if (*p == '=') { p++; get_word_sep(buf, sizeof(buf), ";, ", &p); - if (!strcmp(buf, "record") || - !strcmp(buf, "receive")) + if (!av_strcasecmp(buf, "record") || + !av_strcasecmp(buf, "receive")) th->mode_record = 1; } } diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 39fd92fb66..d6a223cbc6 100644 --- a/libavformat/rtspdec.c +++ b/libavformat/rtspdec.c @@ -303,7 +303,7 @@ static int rtsp_read_setup(AVFormatContext *s, char* host, char *controlurl) rtsp_st->interleaved_min = request.transports[0].interleaved_min; rtsp_st->interleaved_max = request.transports[0].interleaved_max; snprintf(responseheaders, sizeof(responseheaders), "Transport: " - "RTP/AVP/TCP;unicast;mode=receive;interleaved=%d-%d" + "RTP/AVP/TCP;unicast;mode=record;interleaved=%d-%d" "\r\n", request.transports[0].interleaved_min, request.transports[0].interleaved_max); } else { @@ -333,7 +333,7 @@ static int rtsp_read_setup(AVFormatContext *s, char* host, char *controlurl) localport = ff_rtp_get_local_rtp_port(rtsp_st->rtp_handle); snprintf(responseheaders, sizeof(responseheaders), "Transport: " - "RTP/AVP/UDP;unicast;mode=receive;source=%s;" + "RTP/AVP/UDP;unicast;mode=record;source=%s;" "client_port=%d-%d;server_port=%d-%d\r\n", host, request.transports[0].client_port_min, request.transports[0].client_port_max, localport, -- 2.39.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".