Re: [FFmpeg-devel] [PATCH 3/7] avfilter/vf_gblur_vulkan: omit unnecessary buffer usage flag

From: Lynne <dev@lynne.ee>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 3/7] avfilter/vf_gblur_vulkan: omit unnecessary buffer usage flag
Date: Thu, 22 May 2025 06:32:42 +0900
Message-ID: <f689211b-61b5-4e54-a3a2-5d6a50f2c802@lynne.ee> (raw)
In-Reply-To: <20250518121152.94947-3-ffmpeg@haasn.xyz>

[-- Attachment #1.1.1.1: Type: text/plain, Size: 982 bytes --]

On 18/05/2025 21:11, Niklas Haas wrote:
> From: Niklas Haas <git@haasn.dev>
> 
> Implied internally now when needed.
> ---
>   libavfilter/vf_gblur_vulkan.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/libavfilter/vf_gblur_vulkan.c b/libavfilter/vf_gblur_vulkan.c
> index 80b66de735..fb676a7fc9 100644
> --- a/libavfilter/vf_gblur_vulkan.c
> +++ b/libavfilter/vf_gblur_vulkan.c
> @@ -171,7 +171,6 @@ static int init_gblur_pipeline(GBlurVulkanContext *s,
>       RET(ff_vk_shader_register_exec(&s->vkctx, &s->e, shd));
>   
>       RET(ff_vk_create_buf(&s->vkctx, params_buf, sizeof(float) * ksize, NULL, NULL,
> -                         VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT |
>                            VK_BUFFER_USAGE_STORAGE_BUFFER_BIT,
>                            VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT));
>       RET(ff_vk_map_buffer(&s->vkctx, params_buf, &kernel_mapped, 0));

Its used in a lot more places than here, but its a start.

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".