* [FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include
@ 2024-03-24 2:24 Marth64
2024-03-24 17:31 ` Leo Izen
0 siblings, 1 reply; 7+ messages in thread
From: Marth64 @ 2024-03-24 2:24 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Marth64
Since log statements printing int64 were made portable in
4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include
inttypes.h explicitly (as it is unclear where PRId64 and
such are coming from now).
Reported-by: Traneptora
Signed-off-by: Marth64 <marth64@proxyid.net>
---
libavformat/dvdvideodec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index 761ac97ec6..959b267e69 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@ -30,6 +30,7 @@
* 7) Close the dvdnav VM, and free dvdread's IFO structures
*/
+#include <inttypes.h>
#include <dvdnav/dvdnav.h>
#include <dvdread/dvd_reader.h>
#include <dvdread/ifo_read.h>
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include
2024-03-24 2:24 [FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include Marth64
@ 2024-03-24 17:31 ` Leo Izen
2024-03-24 19:24 ` Marth64
0 siblings, 1 reply; 7+ messages in thread
From: Leo Izen @ 2024-03-24 17:31 UTC (permalink / raw)
To: ffmpeg-devel
On 3/23/24 22:24, Marth64 wrote:
> Since log statements printing int64 were made portable in
> 4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include
> inttypes.h explicitly (as it is unclear where PRId64 and
> such are coming from now).
>
> Reported-by: Traneptora
> Signed-off-by: Marth64 <marth64@proxyid.net>
> ---
> libavformat/dvdvideodec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
> index 761ac97ec6..959b267e69 100644
> --- a/libavformat/dvdvideodec.c
> +++ b/libavformat/dvdvideodec.c
> @@ -30,6 +30,7 @@
> * 7) Close the dvdnav VM, and free dvdread's IFO structures
> */
>
> +#include <inttypes.h>
> #include <dvdnav/dvdnav.h>
> #include <dvdread/dvd_reader.h>
> #include <dvdread/ifo_read.h>
I would add a space between the inttypes.h include and the dvdread
include because inttypes is a standard C library and the others are an
external library.
If you don't want to do this you'll have to put it afterward in order to
alphabetize it.
- Leo Izen (Traneptora)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include
2024-03-24 17:31 ` Leo Izen
@ 2024-03-24 19:24 ` Marth64
2024-03-25 21:20 ` Marth64
2024-03-25 21:21 ` [FFmpeg-devel] [PATCH v2] " Marth64
0 siblings, 2 replies; 7+ messages in thread
From: Marth64 @ 2024-03-24 19:24 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Will send v2 with fix. I actually prefer it, I wasn't sure if it would be
seen the same way.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include
2024-03-24 19:24 ` Marth64
@ 2024-03-25 21:20 ` Marth64
2024-03-25 21:21 ` [FFmpeg-devel] [PATCH v2] " Marth64
1 sibling, 0 replies; 7+ messages in thread
From: Marth64 @ 2024-03-25 21:20 UTC (permalink / raw)
To: ffmpeg-devel
v2 on the way.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 7+ messages in thread
* [FFmpeg-devel] [PATCH v2] avformat/dvdvideodec: add explicit inttypes.h include
2024-03-24 19:24 ` Marth64
2024-03-25 21:20 ` Marth64
@ 2024-03-25 21:21 ` Marth64
2024-03-26 15:35 ` Stefano Sabatini
1 sibling, 1 reply; 7+ messages in thread
From: Marth64 @ 2024-03-25 21:21 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Marth64
Since log statements printing int64 were made portable in
4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include
inttypes.h explicitly (as it is unclear where PRId64 and
such are coming from now).
Reported-by: Traneptora
Signed-off-by: Marth64 <marth64@proxyid.net>
---
libavformat/dvdvideodec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index 761ac97ec6..4959edab5c 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@ -30,6 +30,8 @@
* 7) Close the dvdnav VM, and free dvdread's IFO structures
*/
+#include <inttypes.h>
+
#include <dvdnav/dvdnav.h>
#include <dvdread/dvd_reader.h>
#include <dvdread/ifo_read.h>
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] avformat/dvdvideodec: add explicit inttypes.h include
2024-03-25 21:21 ` [FFmpeg-devel] [PATCH v2] " Marth64
@ 2024-03-26 15:35 ` Stefano Sabatini
2024-03-26 15:56 ` Marth64
0 siblings, 1 reply; 7+ messages in thread
From: Stefano Sabatini @ 2024-03-26 15:35 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Marth64
On date Monday 2024-03-25 16:21:02 -0500, Marth64 wrote:
> Since log statements printing int64 were made portable in
> 4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include
> inttypes.h explicitly (as it is unclear where PRId64 and
> such are coming from now).
>
> Reported-by: Traneptora
> Signed-off-by: Marth64 <marth64@proxyid.net>
> ---
> libavformat/dvdvideodec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
> index 761ac97ec6..4959edab5c 100644
> --- a/libavformat/dvdvideodec.c
> +++ b/libavformat/dvdvideodec.c
> @@ -30,6 +30,8 @@
> * 7) Close the dvdnav VM, and free dvdread's IFO structures
> */
>
> +#include <inttypes.h>
> +
> #include <dvdnav/dvdnav.h>
> #include <dvdread/dvd_reader.h>
> #include <dvdread/ifo_read.h>
> --
> 2.34.1
LGTM, will apply.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-03-26 15:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-24 2:24 [FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include Marth64
2024-03-24 17:31 ` Leo Izen
2024-03-24 19:24 ` Marth64
2024-03-25 21:20 ` Marth64
2024-03-25 21:21 ` [FFmpeg-devel] [PATCH v2] " Marth64
2024-03-26 15:35 ` Stefano Sabatini
2024-03-26 15:56 ` Marth64
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git