From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6B8444A47C for ; Thu, 28 Mar 2024 11:36:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5004168D68B; Thu, 28 Mar 2024 13:36:41 +0200 (EET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BD6C568D57D for ; Thu, 28 Mar 2024 13:36:35 +0200 (EET) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6e6afb754fcso859102b3a.3 for ; Thu, 28 Mar 2024 04:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711625793; x=1712230593; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Bhjxm+/722loZLGr8LuAC0bVhgmETlzByZJmTADD1bc=; b=bvLb97sp+DZSx5olTFcurTHlYM3+hB9HHWIo0ICDy83UxRQEe6UeVqB1K1bt60lPAD 6sdUMJVatSz6nEkqBGTy8LtWeV9RKdYHsV/3kp5T8KXIyDni6r8ddfNrXIzlHx3EfwkH Gngisi2pQX7pmhHpz8YmTwj7W8RVIZn7IkgXZ6a2ukSjC/KrRL1lrHyAQaygt+H7dtpE NI7nrvrq1OeSsdX+lPJ05v9BY6Lqx4rMAWJ3rtYqEkk++xZ9ZLVTDSqJH+IyK9xJbAPF vRvy0n/8YSoksWrW78sTHOzrE2ywA18OCARKAiZFG6OVCq8f4FTE2/Fz3xq+BKjLkLGN zHtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711625793; x=1712230593; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bhjxm+/722loZLGr8LuAC0bVhgmETlzByZJmTADD1bc=; b=mNr5AvPS0VLjSaKfDbXPcZBBcbmhjZmPeqjoEpysSbDUgWGCMACBCHgWOPP/xw3sjG lQMOgBBJCQ2QCLvF3Syc+4nFe00RTIYmeLk2JDgbBvW7r1pU4z70ZVV4fHI7TIp6eUie RHSDOSgixeN5N4lXw9VsYxebX+drN/AzlcM7kfoJjbg19fdHimO8xqqpzAZVcmTc9EqG nlr5QMW6fju9osDUptaCJCr8Ydk3s2RCMWTdYed6sBz91xdvLVCuDamPD5dAyb6w+7I9 FRYftHAcjPf9Thhrv7w80xHwBK08O88be4Wtrhcs5wqRQqm2U+bydiNCGblnYDa0vZRu PooA== X-Gm-Message-State: AOJu0YzHotw3SdWBpYJgKBTwzOWG1YHYvMe1d7LfenU9dlMvhUegNqnP KwDUdgqAAPcjRRT56Ccy106zescKEboY2PK+7MjiUVB47URr0U+eV6BV8Ob/ X-Google-Smtp-Source: AGHT+IFLH4tPBV1Su9z20Gfe+nephqKmfucFuqgn4XmpIePl6IrIKUFRvk/YxMzJGEDZE0SVwUyPlQ== X-Received: by 2002:a05:6a20:3d17:b0:1a0:efd0:b183 with SMTP id y23-20020a056a203d1700b001a0efd0b183mr3119721pzi.44.1711625793624; Thu, 28 Mar 2024 04:36:33 -0700 (PDT) Received: from [192.168.0.15] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id j4-20020a170902da8400b001e132fe4cabsm1343910plx.88.2024.03.28.04.36.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 04:36:33 -0700 (PDT) Message-ID: Date: Thu, 28 Mar 2024 08:36:37 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240328031210.21407-1-jamrial@gmail.com> <20240328031210.21407-6-jamrial@gmail.com> <171162556968.7287.5765479778642883211@lain.khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: <171162556968.7287.5765479778642883211@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 6/7 v4] avcodec/decode: make the AVFrameSideData helper wrappers not depend on frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/28/2024 8:32 AM, Anton Khirnov wrote: > Quoting James Almer (2024-03-28 04:12:09) >> They will be useful to fill arrays stored in other structs. >> >> Signed-off-by: James Almer >> --- >> libavcodec/av1dec.c | 7 +-- >> libavcodec/cri.c | 3 +- >> libavcodec/decode.c | 99 +++++++++++++++++++++++++++-------------- >> libavcodec/decode.h | 28 ++++++------ >> libavcodec/dpx.c | 3 +- >> libavcodec/h2645_sei.c | 4 +- >> libavcodec/h264_slice.c | 3 +- >> libavcodec/hevcdec.c | 6 ++- >> libavcodec/libdav1d.c | 7 +-- >> libavcodec/libjxldec.c | 3 +- >> libavcodec/mjpegdec.c | 3 +- >> libavcodec/mpeg12dec.c | 11 +++-- >> libavcodec/pngdec.c | 8 ++-- >> libavcodec/qsvdec.c | 4 +- >> libavcodec/tiff.c | 3 +- >> libavcodec/webp.c | 3 +- >> 16 files changed, 120 insertions(+), 75 deletions(-) > > Extra churn in all the decoders, longer and harder to read lines. > Why not make ff_frame_new_side_data_from_buf() a wrapper for a new > function instead? Can you elaborate? I'm making all the decode.h side data wrappers take pointers to AVFrameSideData instead of AVFrames so they're not limited to the latter. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".