Re: [FFmpeg-devel] [PATCH 6/7 v4] avcodec/decode: make the AVFrameSideData helper wrappers not depend on frames

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 6/7 v4] avcodec/decode: make the AVFrameSideData helper wrappers not depend on frames
Date: Thu, 28 Mar 2024 08:36:37 -0300
Message-ID: <f5fcc3af-38d3-460a-b9af-337cff4c5152@gmail.com> (raw)
In-Reply-To: <171162556968.7287.5765479778642883211@lain.khirnov.net>

On 3/28/2024 8:32 AM, Anton Khirnov wrote:
> Quoting James Almer (2024-03-28 04:12:09)
>> They will be useful to fill arrays stored in other structs.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>   libavcodec/av1dec.c     |  7 +--
>>   libavcodec/cri.c        |  3 +-
>>   libavcodec/decode.c     | 99 +++++++++++++++++++++++++++--------------
>>   libavcodec/decode.h     | 28 ++++++------
>>   libavcodec/dpx.c        |  3 +-
>>   libavcodec/h2645_sei.c  |  4 +-
>>   libavcodec/h264_slice.c |  3 +-
>>   libavcodec/hevcdec.c    |  6 ++-
>>   libavcodec/libdav1d.c   |  7 +--
>>   libavcodec/libjxldec.c  |  3 +-
>>   libavcodec/mjpegdec.c   |  3 +-
>>   libavcodec/mpeg12dec.c  | 11 +++--
>>   libavcodec/pngdec.c     |  8 ++--
>>   libavcodec/qsvdec.c     |  4 +-
>>   libavcodec/tiff.c       |  3 +-
>>   libavcodec/webp.c       |  3 +-
>>   16 files changed, 120 insertions(+), 75 deletions(-)
> 
> Extra churn in all the decoders, longer and harder to read lines.
> Why not make ff_frame_new_side_data_from_buf() a wrapper for a new
> function instead?

Can you elaborate? I'm making all the decode.h side data wrappers take 
pointers to AVFrameSideData instead of AVFrames so they're not limited 
to the latter.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".