From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 96F4446D06 for ; Sun, 9 Jul 2023 12:05:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 23EBF68C5D7; Sun, 9 Jul 2023 15:05:52 +0300 (EEST) Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1B53F68C4A0 for ; Sun, 9 Jul 2023 15:05:46 +0300 (EEST) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1b0419f758eso2948990fac.1 for ; Sun, 09 Jul 2023 05:05:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688904344; x=1691496344; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Wko3fKtjxCH0UFuTn3JXF13WYgEJBzjOoHKB6xWheQw=; b=BrSf+D9uv7CrgwkLCXpAyU/uBbI+IfE970u2m6Pe6b9ExE3mjG8e28affuXPRgMym0 vhvbPae11/g232AxiV2s5kMR79u1fLTzZH41tNatYPiZwcC8JuOXRt4N3VmroOD/Cs05 vtsf+ZZ018aaBU7zDIqmn8JP8MDFrzkgMnCBtW09uNjhf0TULzRB/tMREPtEc/RQGGQW 4pVmy9epV/wppwuUAJzsM7BlYj4ph+84En9vJubYGlXYwnHKYEvKgzCsjN/4bsTdWzgg QGDQv9uqWH1TU1Eo61CZCJhmm5uZ9fWjASa1sbrLvqmGrCrRsXEYhuPOc74W5SRd2RyC RXuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688904344; x=1691496344; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wko3fKtjxCH0UFuTn3JXF13WYgEJBzjOoHKB6xWheQw=; b=dC6aGWDXGx9fYuTMAnZn/VK0UzM7wPZfukahUFmtzluYEpWAWQCt2n2HUSEEPISEEZ fFVGf0kxm7BOetvsPUmmu7Lwinv8zyzeRkMoz24c/ovFbf7RmqzghWEECLEFnkrw44Hp L3uAV0erzqc8SJ30YOc3VT3owRzM0/gYL4FovaQfMkAJTJHJbN8u5u7bcubyo/dcB87j spOnu+y5Xynabe02L/rmpH5DJyTOVcUsxHQmnmG0peEnf4GCePbR5Hs40FTwpWCYo1ll HXQPP3Pn0PFBDBbFnQooqpryO9SsG5t58tnJmCgNo/jkOZ2MREFcC68Q4IHdE3PPbUVi nlyg== X-Gm-Message-State: ABy/qLajqz6wrYEW2GrD5eg50ORHgH1TzNtNjLuQWcnA7Ro3dAKf+MnG gzwXnvUL/63LnMHiPQO/9p5Ew/5UR4U= X-Google-Smtp-Source: APBJJlE+4p+IT6KlUOvhnfMlDqCGwXriX3Lif6q/yvYItBxlsk1DuGuUhQWFGjhSHgZEHoE/enTTBA== X-Received: by 2002:a05:6870:e0cd:b0:1b0:24d0:5554 with SMTP id a13-20020a056870e0cd00b001b024d05554mr6324140oab.11.1688904344032; Sun, 09 Jul 2023 05:05:44 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id dx26-20020a056870769a00b001a68feb9440sm3509764oab.9.2023.07.09.05.05.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Jul 2023 05:05:43 -0700 (PDT) Message-ID: Date: Sun, 9 Jul 2023 09:05:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230708190038.24324-1-jamrial@gmail.com> <20230708190038.24324-3-jamrial@gmail.com> <168889619587.542.7376351668865015515@lain.khirnov.net> From: James Almer In-Reply-To: <168889619587.542.7376351668865015515@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/decode: fill missing frame fields for all decoders X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/9/2023 6:49 AM, Anton Khirnov wrote: > Quoting James Almer (2023-07-08 21:00:38) >> And not just those with the old decode() API. >> >> Signed-off-by: James Almer >> --- >> libavcodec/decode.c | 52 +++++++++++++++++++++++---------------------- >> 1 file changed, 27 insertions(+), 25 deletions(-) > > Is there a functional reason for this patch? > > I've been wondering recently about dropping this code entirely, because > get_buffer() should always fill those fields. Decoders that don't use get_buffer at all exist. If they don't fill all frame fields, this would. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".