From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5C4A04A7A3 for ; Tue, 9 Apr 2024 08:59:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 422D368D1B3; Tue, 9 Apr 2024 11:59:11 +0300 (EEST) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7802368CB6E for ; Tue, 9 Apr 2024 11:59:04 +0300 (EEST) Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-516d0162fa1so6351457e87.3 for ; Tue, 09 Apr 2024 01:59:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1712653143; x=1713257943; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=SEikHzxx31lp46pRCZ7uts3Qd4RxFn7mB5CPb3xT+Yo=; b=QW/n3dWebxMyeXX88gIhXlRF1DsiZMcbvRbqXnvzqlDGNU+KplW8nj9q2VIkNtjN7B EyNc0r116uGRgcIjhMnPt4dhMUJCL7q5HZUArjURCwbxjq0T0lzgC8Zm/jUpa7bL5Rkb fMEgPDKtdOdGNz97xyxg42DTC1V6jsw3jsqDhbzxIro0EqJuIAqLqsXsRB5wLm9/FQxB B+xu07jtml+OKSEehKfwjTxxsvWUnkzGiiv3VWi/Dqj2oXqKLz5n/hVuhbh9qss24kLo wJXjyMu976wYOJj/joa9aCO5+nEHfWmG4aKS3BK19CdFGv/3gpmBBYVhfy6G4465GEEj 0NqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712653143; x=1713257943; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SEikHzxx31lp46pRCZ7uts3Qd4RxFn7mB5CPb3xT+Yo=; b=w1aN1yvEjH/yqpQ0acc27hp99FkOpmtpmkCYNvDWOZKEcnTZwKanM/BF2OsDHUe222 snCROFmXNZUMUaT3KvYqFdMLsLqOzJ9cjU2ThVn1/nDn4gVpZrQtqDnwPX5RpJSL2EJk g5E4tmVx7HGB5KSLbthUDT0C1R+sNZ1uqgdWU0CxCKpSjfFwC2vLiHqfo+gfwrk4/cDj dqD4Ug+TcaL1yW+2UZfFLzivjNsGlUWK8UIF/bQNE6a0nrSbsLNS0jTc5g6fSPDa/r5D CLpFdQ+dNZWgunG1bVWZzIXvCFUbRZdSY8pz4DHuO3aKzSgkXVMIwI47G+3zSRBrDos2 RX1g== X-Gm-Message-State: AOJu0YwxXwd8qInX7fxuQO6aA2Y8w8l+VIjk+0FWYMuhtd88EWAtRplU YtTrAEa7hL9MfIzIWfP8GjQZX8i2EghQ7O+e9xVR2Dpduk4RrbvZfLIlwYLFelujhzxG98WOTtS lVA== X-Google-Smtp-Source: AGHT+IFiG8dA0Cj8NLr8WKLN4Va/jTYA3+TTbuAigSmOH2PnvmyNZhzfMFXAt1DnztCa8tL+jG7Uiw== X-Received: by 2002:a19:ad0b:0:b0:516:d264:1ce8 with SMTP id t11-20020a19ad0b000000b00516d2641ce8mr7637562lfc.19.1712653143241; Tue, 09 Apr 2024 01:59:03 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id z6-20020a056512308600b00516d05bb083sm943039lfd.206.2024.04.09.01.59.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 01:59:03 -0700 (PDT) Date: Tue, 9 Apr 2024 11:58:58 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20240408131600.81682-1-jdek@itanimul.li> Message-ID: References: <20240408131600.81682-1-jdek@itanimul.li> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] configure, etc: unify shebang usage X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 8 Apr 2024, J. Dekker wrote: > In some cases, these scripts can be called directly by packagers, and > some systems require the interpreter to be explicit. It is unclear to me which of the changes are needed and for what reason, please elaborate much more in the commit message. Is it possible to elaborate on "some systems require the interpreter to be explicit"? It'd be much nicer to reason about if there was a concrete example of such a case (even if it certainly is right to add the missing shebang line). The changes I see fall into these categories: - Change "#! " into "#!. Does this change have a functional effect for someone (where, and why?) or is it purely a cosmetic change? - Add a shebang line in the generated ffbuild/config.sh. This script is highly unlikely to be useful to call on its own like that, so while this probably is good for consistency I don't see it ever making a difference. - Add a shebang line in ffbuild/libversion.sh. I can see the value in calling this script directly, outside of our build system. I presume this is the actual change that makes a difference here? I don't mind the changes, but I'd prefer to split them into two separate commits; add missing shebangs (with an example of the case where it really does make a difference), vs removing extra spaces in shebangs for consistency (with explicit clarification in the commit message whether this is only for stylistic consistency or whether it does make a difference somewhere, and if it does, where). // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".