From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CAD9C407B8 for ; Wed, 28 Dec 2022 08:04:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 04EAD68B757; Wed, 28 Dec 2022 10:04:50 +0200 (EET) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A3D9F6802C4 for ; Wed, 28 Dec 2022 10:04:43 +0200 (EET) Received: from kwepemi100013.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NhkV73XPyz9t1R for ; Wed, 28 Dec 2022 16:00:47 +0800 (CST) Received: from kwepemi500014.china.huawei.com (7.221.188.232) by kwepemi100013.china.huawei.com (7.221.188.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 28 Dec 2022 16:04:39 +0800 Received: from kwepemi500014.china.huawei.com ([7.221.188.232]) by kwepemi500014.china.huawei.com ([7.221.188.232]) with mapi id 15.01.2375.034; Wed, 28 Dec 2022 16:04:39 +0800 From: "Wujian(Chin)" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*) Thread-Index: AdkZKwoRoi0uY0dPRESbmQpbQziRdQAvjMyAACo41dA= Date: Wed, 28 Dec 2022 08:04:39 +0000 Message-ID: References: <20221227194913.GR3806951@pb2> In-Reply-To: <20221227194913.GR3806951@pb2> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.136.102.143] MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: [FFmpeg-devel] =?gb2312?b?tPC4tDogIFtQQVRDSF0gZmZ0b29scy9mZm1w?= =?gb2312?b?ZWdfZmZwbGF5X2ZmcHJvYmVfY21kdXRpbHM6IGFkZCAtbWFza191cmwgdG8g?= =?gb2312?b?cmVwbGFjZSB0aGUgcHJvdG9jb2wgYWRkcmVzcyBpbiB0aGUgY29tbWFuZCB3?= =?gb2312?b?aXRoIHRoZSBhc3RlcmlzayAoKik=?= X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >On Mon, Dec 26, 2022 at 01:07:51PM +0000, Wujian(Chin) wrote: >> The issue has been modified. Please review again, thank you! >> >> Signed-off-by: wujian_nanjing >> --- >> doc/fftools-common-opts.texi | 11 +++++++ >> fftools/cmdutils.c | 77 ++++++++++++++++++++++++++++++++++++++++++-- >> fftools/cmdutils.h | 25 ++++++++++++++ >> fftools/ffmpeg.c | 10 +++--- >> fftools/ffplay.c | 9 ++++-- >> fftools/ffprobe.c | 10 +++--- >> 6 files changed, 128 insertions(+), 14 deletions(-) >ffmpeg -h >segfaults with this patch >==32366== Invalid read of size 8 I have reproduced the problem. The reason is that the last element of argv_copy does not end with null. Otherwise, this problem will occur. Thanks. >==32366== at 0x30836B: split_commandline (in ffmpeg/ffmpeg_g) >==32366== by 0x3039CD: ffmpeg_parse_options (in ffmpeg/ffmpeg_g) >==32366== by 0x2ED201: main (in ffmpeg/ffmpeg_g) >==32366== Address 0x2ced5290 is 0 bytes after a block of size 16 alloc'd >==32366== at 0x4C33E76: memalign (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) >==32366== by 0x4C33F91: posix_memalign (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) >==32366== by 0x116B322: av_malloc (in ffmpeg/ffmpeg_g) >==32366== by 0x116B4D8: av_mallocz (in ffmpeg/ffmpeg_g) >==32366== by 0x306469: copy_argv (in ffmpeg/ffmpeg_g) >==32366== by 0x306537: handle_arg_param (in ffmpeg/ffmpeg_g) >==32366== by 0x2ED1F5: main (in ffmpeg/ffmpeg_g) >==32366== > [...] >-- >Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB >Opposition brings concord. Out of discord comes the fairest harmony. >-- Heraclitus _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".