From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id BC26E4A28B for ; Thu, 17 Jul 2025 11:54:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 98D4768EDE5; Thu, 17 Jul 2025 14:54:21 +0300 (EEST) Received: from vidala.pars.ee (vidala.pars.ee [116.203.72.101]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id D7ECE68ED6D for ; Thu, 17 Jul 2025 14:54:14 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; s=202405r; d=lynne.ee; c=relaxed/relaxed; h=From:To:Subject:Date:Message-ID; t=1752753253; bh=8CNISVoITJO1UK2m8YJyKzJ oQOFKs6hw4upQcp9jNy4=; b=BOwBMZEAI4XA6GEttSpeuTJleefixCrR125fhLUelbbfPb/sQ7 PLzSw2tu1vtr5qo3OFGDAAlqkcOt7yQtrIhFpDts5xrBHDJKGO7zk1Znt0TDocjwnDfZ5GVu21O 4nO0wFbeDVdL6gTvetotGXA1j0JwsroO7zxbpRJ7tnxXbqwlBCGoTTtifRrLJ91bk894DIvhWnQ zKswu/OJkkpijuHoaBGKrMI0cXFwkkhbKOp4R+LHoTbvt1RFhGXcYUQdyoOENGO8uqah29F/Yft QvR0KzdQplASwIanHXoTGdUWH3Zg0i9x2Oio5iZLVcniOvs6kzrMKrkH42ejXQArxaw==; DKIM-Signature: v=1; a=ed25519-sha256; s=202405e; d=lynne.ee; c=relaxed/relaxed; h=From:To:Subject:Date:Message-ID; t=1752753253; bh=8CNISVoITJO1UK2m8YJyKzJ oQOFKs6hw4upQcp9jNy4=; b=STMNbR4KG1hde7KnYx/Zt2KN9CPzzNrFGDvTSwfskARwpVMTaJ 9bx1buWpZHM6fYAhqCd2VYicsyg9C/XgLXDQ==; Message-ID: Date: Thu, 17 Jul 2025 20:54:09 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250717023057.678-1-erj@erj.cc> <20250717023057.678-3-erj@erj.cc> Content-Language: en-US From: Lynne In-Reply-To: <20250717023057.678-3-erj@erj.cc> Subject: Re: [FFmpeg-devel] [PATCH 2/2] libavformat: Enable jpeg streams in HEIF MOVContext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Thanks. Patchset LGTM. This also helps HEIF files generated by the S1II, but sadly they still fail: > [mjpeg @ 0x55a49a0e29c0] No JPEG data found in image And for the main stream: > [hevc @ 0x55a49a0fe880] Failed to parse header of NALU (type 34): "Invalid data found when processing input". Skipping NALU. > [hevc @ 0x55a49a0fe880] Invalid NAL unit size (1229531648 > 102386). > [hevc @ 0x55a49a0fe880] Error splitting the input into NAL units. > [vist#0:0/hevc @ 0x55a49a0e5000] [dec:hevc @ 0x55a49a103a80] Decoding error: Invalid data found when processing input I wonder what they're doing with the thumbnail and NALUs. If you'd like to take a look at it, here's a sample: https://files.lynne.ee/P1001083.HIF On 17/07/2025 11:30, Eric Joyner wrote: > Nikon HEIFs from a camera or NX studio include a small jpeg thumbnail in addition to > the expected HEVC thumbnails; allowing jpegs allows all thumbnails to > have an associated stream for Nikon HEIF files. > > With this, Nikon HEIFs can finally be decoded without failing and the > thumbnails can be extracted into their own files. > > Signed-off-by: Eric Joyner > --- > libavformat/mov.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 7010e13b50..19b31b032d 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -8840,6 +8840,7 @@ static int mov_read_infe(MOVContext *c, AVIOContext *pb, MOVAtom atom, int idx) > > switch (item_type) { > case MKTAG('a','v','0','1'): > + case MKTAG('j','p','e','g'): > case MKTAG('h','v','c','1'): > ret = heif_add_stream(c, c->heif_item[idx]); > if (ret < 0) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".