From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 82A6145953 for ; Tue, 28 Mar 2023 20:42:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 25D4268CC4B; Tue, 28 Mar 2023 23:42:41 +0300 (EEST) Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AE5C068CC44 for ; Tue, 28 Mar 2023 23:42:34 +0300 (EEST) Received: by mail-oi1-f170.google.com with SMTP id bm2so10011517oib.4 for ; Tue, 28 Mar 2023 13:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680036152; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jooTFO9qbPdbf/Flyv6Vdmt45H4TNF0jmrlnkv7m1es=; b=LV4OcIKORsVjzt4SMcdFeWkQ8IZMvN71vceCcuedWF0SdPxXr1ypalLzzHQyvVUKqH ulzB0rhwtk+Y90C5tQWJhOoOOM4oqONa0jT/Y3ufLoOHauA23/SFhUnO2RJqv8Nd3E7W 2d/gfZa0wTpcJaoePY6bIympHzyjsnxm6vv0OniC83p0towc8cJjBTmYjx4z49DEprGM bSZ5E0Oz9NLk2s2PiqkjXtgNOxoT2RS407ZYnCYKR3AnlJNBgFYIID6vNbrMI2aJ8ADz HxRnGKaNMNXJ33k4jb6kiA9SlBNbMNJhvAoBwniF/MQSLlmQqQ8MppoIOe7BEhsIjcDn m4Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680036152; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jooTFO9qbPdbf/Flyv6Vdmt45H4TNF0jmrlnkv7m1es=; b=YLZQe73LlfGdq7+9iuYB80yXfT83JJpOgXoNVtqBB4/1fSwzUi5pBx0bf3lc7btoPr smTosn8c+vQaFtn1SK3sGpT8GW24rWigZhVixiFkd8faIr7if0mH+QC+2Lr5cI6KLM9v DqfUP7uvDHmU2YxAxB0el/Ea6R9sG/KzQ3rb6hImazd0OHQk8k2TLpS41XEJo362LQkI gJ+wMLiUxKNa6cvOxYYad/Ze2HN8xvOyPXkmvo1S3UZbs5grjl8AFAbYmKS0gj61U1+U Zj5b4IZnj5vWZ5qlq8UpvJEDxMr01a2I/9Y17hLmyWhTMV34/Grxk9oUuVlIsJDYDq6Z Y9Ow== X-Gm-Message-State: AO0yUKUT0g0xZCtL2OL4LtE+TVJG5o8bmbMNK357XsJa3TWQVAevkRGa Ln90CQ42PLGHev5NVYYAMgnfL3+znyI= X-Google-Smtp-Source: AK7set8DhqjFB8MVvDEqkJ2jlmkFbusE218E5qFri/zulTjO6iKYhvnyP4oar9px5RW/kruPwOd8wg== X-Received: by 2002:a54:4583:0:b0:384:1793:90cf with SMTP id z3-20020a544583000000b00384179390cfmr7217901oib.0.1680036152386; Tue, 28 Mar 2023 13:42:32 -0700 (PDT) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id k126-20020acaba84000000b00386eff32f58sm11042235oif.13.2023.03.28.13.42.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Mar 2023 13:42:31 -0700 (PDT) Message-ID: Date: Tue, 28 Mar 2023 17:42:28 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230328203226.34753-1-rcombs@rcombs.me> From: James Almer In-Reply-To: <20230328203226.34753-1-rcombs@rcombs.me> Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc/vorbis_parser: quiet log on unrecognized packet types X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/28/2023 5:32 PM, rcombs wrote: > --- > libavcodec/vorbis_parser.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/vorbis_parser.c b/libavcodec/vorbis_parser.c > index a7d15d4ce9..65ad3fe2a5 100644 > --- a/libavcodec/vorbis_parser.c > +++ b/libavcodec/vorbis_parser.c > @@ -234,7 +234,8 @@ int av_vorbis_parse_frame_flags(AVVorbisParseContext *s, const uint8_t *buf, > else if (buf[0] == 5) > *flags |= VORBIS_FLAG_SETUP; > else > - goto bad_packet; > + av_log(s, AV_LOG_VERBOSE, "Ignoring packet with unknown type %i\n", > + buf[0]); > > /* Special packets have no duration. */ > return 0; nit: commit message is wrong since you're not just logging, you're also now ignoring them instead of failing. So maybe "lavc/vorbis_parser: ignore unrecognized packet types". LGTM otherwise. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".