From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] libavcodec/qsvenc: add more ChromaFormat support to mjpeg_qsv
Date: Mon, 28 Feb 2022 06:38:25 +0000
Message-ID: <f3f2b9f5f897642443fc02570754c40db9e19a46.camel@intel.com> (raw)
In-Reply-To: <20220221072833.967303-1-wenbin.chen@intel.com>
On Mon, 2022-02-21 at 15:28 +0800, Wenbin Chen wrote:
> ChromaForamt for mjpeg-qsv is always set to yuv420, and this will be
> wrong when encode other pixel format (for example yuyv422). ChromaFormat
> is changed to be adaptive to pix_fmt.
>
> Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
> ---
> libavcodec/qsvenc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> index 07be4287b7..3d9dfb13b0 100644
> --- a/libavcodec/qsvenc.c
> +++ b/libavcodec/qsvenc.c
> @@ -616,7 +616,8 @@ static int init_video_param_jpeg(AVCodecContext *avctx,
> QSVEncContext *q)
> q->param.mfx.FrameInfo.CropH = avctx->height;
> q->param.mfx.FrameInfo.AspectRatioW = avctx->sample_aspect_ratio.num;
> q->param.mfx.FrameInfo.AspectRatioH = avctx->sample_aspect_ratio.den;
> - q->param.mfx.FrameInfo.ChromaFormat = MFX_CHROMAFORMAT_YUV420;
> + q->param.mfx.FrameInfo.ChromaFormat = MFX_CHROMAFORMAT_YUV420 +
> + !desc->log2_chroma_w + !desc-
> >log2_chroma_h;
> q->param.mfx.FrameInfo.BitDepthLuma = desc->comp[0].depth;
> q->param.mfx.FrameInfo.BitDepthChroma = desc->comp[0].depth;
> q->param.mfx.FrameInfo.Shift = desc->comp[0].depth > 8;
LGTM and applied, thx
-Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-02-28 6:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 7:28 Wenbin Chen
2022-02-28 6:38 ` Xiang, Haihao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3f2b9f5f897642443fc02570754c40db9e19a46.camel@intel.com \
--to=haihao.xiang-at-intel.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git