Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4 01/16] pixfmt: add AV_PIX_FMT_GBRAP32
Date: Fri, 14 Mar 2025 19:34:11 +0100 (CET)
Message-ID: <f38e96be-8504-74a9-4534-8fc049a6b05d@passwd.hu> (raw)
In-Reply-To: <ac7412f8-76ab-4e6c-ac08-daaed8c31ade@lynne.ee>



On Fri, 14 Mar 2025, Lynne wrote:

> On 14/03/2025 16:13, Michael Niedermayer wrote:
>>  On Thu, Mar 13, 2025 at 06:03:33PM +0100, Lynne wrote:
>>>  This commit adds a 32-bit *integer* planar RGBA format.
>>>  Vulkan FFv1 decoding is best performed on separate planes, rather than
>>>  packed RGBA (i.e. RGBA128), hence this is useful as an intermediate
>>>  format.
>>>  ---
>>>    libavutil/pixdesc.c | 28 ++++++++++++++++++++++++++++
>>>    libavutil/pixfmt.h  |  4 ++++
>>>    2 files changed, 32 insertions(+)
>>
>>  breaks fate
>>
>>  --- ./tests/ref/fate/imgutils	2025-03-14 00:56:35.182435551 +0100
>>  +++ tests/data/fate/imgutils	2025-03-14 16:12:30.642340871 +0100
>>  @@ -296,6 +296,8 @@
>>    yaf32le         planes: 1, linesizes: 512   0   0   0, plane_sizes:
>>    24576     0     0     0, plane_offsets:     0     0     0, total_size:
>>    24576
>>    yaf16be         planes: 1, linesizes: 256   0   0   0, plane_sizes:
>>    12288     0     0     0, plane_offsets:     0     0     0, total_size:
>>    12288
>>    yaf16le         planes: 1, linesizes: 256   0   0   0, plane_sizes:
>>    12288     0     0     0, plane_offsets:     0     0     0, total_size:
>>    12288
>>  +gbrap32be       planes: 4, linesizes: 256 256 256 256, plane_sizes: 12288
>>  12288 12288 12288, plane_offsets: 12288 12288 12288, total_size: 49152
>>  +gbrap32le       planes: 4, linesizes: 256 256 256 256, plane_sizes: 12288
>>  12288 12288 12288, plane_offsets: 12288 12288 12288, total_size: 49152
>>
>>    image_fill_black tests
>>    yuv420p         total_size:   4608,  black_unknown_crc: 0xd00f6cc6,
>>    black_tv_crc: 0xd00f6cc6,  black_pc_crc: 0x234969af
>>  @@ -539,3 +541,5 @@
>>    yaf32le         total_size:  24576,  black_unknown_crc: 0xfd900236,
>>    black_tv_crc: 0xfd900236,  black_pc_crc: 0xdcaf0cb1
>>    yaf16be         total_size:  12288,  black_unknown_crc: 0x7afe9aae,
>>    black_tv_crc: 0x7afe9aae,  black_pc_crc: 0x0fc0a5d0
>>    yaf16le         total_size:  12288,  black_unknown_crc: 0x94c0068b,
>>    black_tv_crc: 0x94c0068b,  black_pc_crc: 0xc05ce449
>>  +gbrap32be       total_size:  49152,  black_unknown_crc: 0x7bd30c95,
>>  black_tv_crc: 0x7bd30c95,  black_pc_crc: 0x7bd30c95
>>  +gbrap32le       total_size:  49152,  black_unknown_crc: 0x7bd30c95,
>>  black_tv_crc: 0x7bd30c95,  black_pc_crc: 0x7bd30c95
>>  Test imgutils failed. Look at tests/data/fate/imgutils.err for details.
>>  make: *** [tests/Makefile:311: fate-imgutils] Error 1
>
> I know. Was planning on fixing fate tests when I push, since it makes 
> rebasing easier.

I don't think this is a good practice. It makes patch review or testing 
harder, the fact that a patch changes fate is useful information for 
reviewer. Not to mention that you can easily forgot to update the fate 
references before push, and a pushed commit which fails fate is a bad 
thing. So please, do not send patches which fails to pass fate.

Thanks,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-03-14 18:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13 17:03 [FFmpeg-devel] [PATCH v4 00/16] Add a Vulkan compute based FFv1 hwaccel Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 01/16] pixfmt: add AV_PIX_FMT_GBRAP32 Lynne
2025-03-14 15:13   ` Michael Niedermayer
2025-03-14 15:59     ` Lynne
2025-03-14 18:34       ` Marton Balint [this message]
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 02/16] vulkan: rename ff_vk_set_descriptor_image to ff_vk_shader_update_img Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 03/16] vulkan: add ff_vk_create_imageview Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 04/16] vulkan: copy host-mapping buffer code from hwcontext Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 05/16] hwcontext_vulkan: use the common host map function to map frame data Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 06/16] vulkan: workaround BGR storage image undefined behaviour Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 07/16] vulkan_decode: support software-defined decoders Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 08/16] vulkan_decode: support multiple image views Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 09/16] vulkan_decode: adjust number of async contexts created Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 10/16] ffv1enc_vulkan: refactor shaders slightly to support sharing Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 11/16] vulkan: unify handling of BGR and simplify ffv1_rct Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 12/16] vulkan: add ff_vk_exec_add_dep_wait_sem() Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 13/16] vulkan: add support for AV_PIX_FMT_GBRAP32 Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 14/16] ffv1dec: add support for hwaccels Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 15/16] FFHWAccel: add buffer_ref argument to start_frame Lynne
2025-03-13 22:08   ` Andreas Rheinhardt
2025-03-13 23:03     ` Lynne
2025-03-14  2:23       ` Lynne
2025-03-13 17:03 ` [FFmpeg-devel] [PATCH v4 16/16] ffv1: add a Vulkan-based decoder Lynne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f38e96be-8504-74a9-4534-8fc049a6b05d@passwd.hu \
    --to=cus@passwd.hu \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git