From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2778F4717B for ; Tue, 10 Oct 2023 11:13:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 247BF68CAEE; Tue, 10 Oct 2023 14:13:32 +0300 (EEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7A7B768C954 for ; Tue, 10 Oct 2023 14:13:26 +0300 (EEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-692c70bc440so4202197b3a.3 for ; Tue, 10 Oct 2023 04:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696936404; x=1697541204; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=DtQexgWSShpRy240iskVJdsvedWXq/NcJ6Wm4Wl4xHc=; b=iMhhh4hzq5htgrVCFgMhut0d6ISZJiebTA1wvQB2NFAScLnvyJ/U6+hIjXrwAnkfF2 +P9MBTCHRJ2lYCBLsGIWJykhgSec3M1DI8k+QlYPRzXFzQexfDBKDsqIimItWOutmMuH NDIHR0gEaqU1Vcu1XvQ2otjExvshEKvfwIuBEbWoAd5P5cl37oF9dhCENXcNQASVaIBi +gu/yxqX6sUC08JnfT2OmKAkuvUrn5HAGHxJMv7fG4z8EqEhwBntvaT0bK+8/ha9163V 9Kd5t/rm1JMy8cH3GqQiBWQEpVFMCFNDQjwh4VcWinLtHGWq+he61eljZMyjc91/GWZM yuoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696936404; x=1697541204; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DtQexgWSShpRy240iskVJdsvedWXq/NcJ6Wm4Wl4xHc=; b=uwd8Vt82h6T4N8ta2QxginGsPnFB45LKws4G6bEEU2kBTcBTSSzZxF2l/NI57DHqdv Rl2uaAU1mDmfQNH1y4BgnbOWI6qAFI6xYAc7O+T71S1DkoDVEpea7tjD7YJbu7m4xPWo PM7GZ8yudsMuONx20RIjj0AXbfU+2/Q+oWw19SddO8pCJjzNRyVdj69VbA8sMjCCAjLI X2MUPJAHmnkpTeTV6daSW7xmToMK0BN/Pk9vOaS5ECIsNXykegJmyE6hBc2O1l9xPtOR aXHTcqg5j5inQNzrqoJUDo0y05c+2IbvsqQIFU2BNk2P6OCpuG5rO2IOJfZ3ktTi4lFp mKTQ== X-Gm-Message-State: AOJu0YzznYC8iGOozPNRp51UjSWTrwLdvwB2Vw+x0Onzj19XhvzOFxof A49ur6NNM6IV+r8KB8r3ppBWLsXB2nc= X-Google-Smtp-Source: AGHT+IEk+r1ouk8lJkNYCPbCdrcnxw7IEnfNTteNzZ36F+cGKjhrcp0EiSKhtK1my0jRtDB5OKh5RA== X-Received: by 2002:a05:6a00:24c4:b0:68e:3eab:9e1b with SMTP id d4-20020a056a0024c400b0068e3eab9e1bmr18538772pfv.22.1696936403709; Tue, 10 Oct 2023 04:13:23 -0700 (PDT) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id fn6-20020a056a002fc600b0069302c3c054sm8014121pfb.207.2023.10.10.04.13.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Oct 2023 04:13:23 -0700 (PDT) Message-ID: Date: Tue, 10 Oct 2023 08:13:46 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231007162503.1057-1-jamrial@gmail.com> <20231007162503.1057-5-jamrial@gmail.com> <169693619274.6638.10416615280449969394@lain.khirnov.net> Content-Language: en-US From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <169693619274.6638.10416615280449969394@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 4/7] avformat/avformat: add a flag to signal muxers that support storing cropping values X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 10/10/2023 8:09 AM, Anton Khirnov wrote: > Quoting James Almer (2023-10-07 18:25:00) >> Signed-off-by: James Almer >> --- >> libavformat/avformat.h | 1 + >> libavformat/mux.c | 8 ++++++++ >> 2 files changed, 9 insertions(+) >> >> diff --git a/libavformat/avformat.h b/libavformat/avformat.h >> index 9e7eca007e..c099ca8a01 100644 >> --- a/libavformat/avformat.h >> +++ b/libavformat/avformat.h >> @@ -500,6 +500,7 @@ typedef struct AVProbeData { >> The user or muxer can override this through >> AVFormatContext.avoid_negative_ts >> */ >> +#define AVFMT_CROPPING 0x80000 /**< Format supports storing cropping values */ > > I have mixed feeelings about this patch, for a bunch of reasons: > * It is quite ad-hoc - we don't do this for other side data types, and > this approach would not scale if we did. > * If we do want to signal this, we probably want to distinguish between > support for global and per-packet values. This patch came to be after some discussion from the first iteration of the set, where concerns about the cropping information being silently lost if apply_cropping was disabled during a transcoding or codec copy scenario where the output format didn't support storing said values. > * How do you expect this to be useful to the callers? I don't see this > flag actually being used in the ffmpeg CLI patch. It's a format flag. Muxers use it, and the generic mux.c code will print a warning if needed. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".