From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 59D7E40DE9 for ; Fri, 31 Dec 2021 10:40:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 314DB68AF88; Fri, 31 Dec 2021 12:40:13 +0200 (EET) Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DEE83680097 for ; Fri, 31 Dec 2021 12:40:06 +0200 (EET) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zanevaniperen.com; s=key1; t=1640947205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GZMs2VDBBcoXIrNzEnNbGYKuC671Q7hbzM+bw8Z6llA=; b=SrU92dRJurftLnF8IMUNiMG+Yg7an5dbFU83Ljj2qJCeyiN2zr2T8xcR28P+qKQd/HsQ4p LB2MT4ll3dhhu1UXyMPlyO+cdD+46WlecBrsHAFKWcI6CAtZEU57P2rWkGRYc1fQP4sv9F 27RNc/ZDKIQYSJ755036cL6FZehSC9KCRr1KFwVhpDleG5atrZKItLGEs7Ud+vffJHSX6U 06HwSxVvzvyCXdYURoE55Fx7JdEjYQOsu8vDcloSO4J09PiRtkGPVYlVql5juNb3VWqfrH 7TswjL8zglS7Qa6h/xd4F0E3zqfCkuIyVrIkssAWKtGIBRF82QuHDf7f1Th6NA== Date: Fri, 31 Dec 2021 20:39:59 +1000 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20211227004758.26381-1-pal@sandflow.com> <712adaf9-2b23-63c8-0779-1eb5f1cfde3e@zanevaniperen.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zane van Iperen In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: zanevaniperen.com Subject: Re: [FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Pierre-Anthony Lemieux Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 31/12/21 19:40, Paul B Mahol wrote: > Why was this applied? >> >> Both patches lgtm, I'll apply in a few days if no objections. >> No one objected. > It still breaks style of ffmpeg code, just from quick glance. > Which parts specifically? The main potential issue I can see is the long scanf() in ff_imf_xml_read_uuid(). This, however, is only temporary as Pierre is working on replacing all the ad-hoc UUID stuff in ffmpeg with libuuid. If it's the av_log()s with parameters on newlines, that's also done in libavcodec/videotoolboxenc.c. If we're really *that* pedantic about it, I'll reformat things myself and submit a patch... > Please revert or I leave this project forever. > This is the internet, humor doesn't survive over email. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".