Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Zane van Iperen <zane@zanevaniperen.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Pierre-Anthony Lemieux <pal@sandflow.com>
Subject: Re: [FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer
Date: Fri, 31 Dec 2021 20:39:59 +1000
Message-ID: <f332aaf7-d445-f3b7-7f76-20ce0a708484@zanevaniperen.com> (raw)
In-Reply-To: <CAPYw7P7arHL9F=YZVoub1h4A8Azr3dFpHCB7TCoquCRO8TVsAw@mail.gmail.com>



On 31/12/21 19:40, Paul B Mahol wrote:
> Why was this applied?

>>
>> Both patches lgtm, I'll apply in a few days if no objections.
>>

No one objected.


> It still breaks style of ffmpeg code, just from quick glance.
> 
Which parts specifically?

The main potential issue I can see is the long scanf() in ff_imf_xml_read_uuid().
This, however, is only temporary as Pierre is working on replacing all the ad-hoc UUID
stuff in ffmpeg with libuuid.

If it's the av_log()s with parameters on newlines, that's also done in libavcodec/videotoolboxenc.c.

If we're really *that* pedantic about it, I'll reformat things myself and submit a patch...

> Please revert or I leave this project forever.
> 

This is the internet, humor doesn't survive over email.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2021-12-31 10:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-27  0:47 pal
2021-12-27  0:47 ` [FFmpeg-devel] [PATCH v15 2/2] avformat/imf: Tests pal
2021-12-28  5:28 ` [FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer Zane van Iperen
2021-12-31  9:40   ` Paul B Mahol
2021-12-31 10:39     ` Zane van Iperen [this message]
2021-12-31 11:19       ` Paul B Mahol
2021-12-31 13:25         ` Zane van Iperen
2021-12-31 13:33           ` Lynne
2022-01-07  8:15           ` Paul B Mahol
2022-01-07 16:12             ` Pierre-Anthony Lemieux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f332aaf7-d445-f3b7-7f76-20ce0a708484@zanevaniperen.com \
    --to=zane@zanevaniperen.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=pal@sandflow.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git