From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7DF3E410DC for ; Wed, 16 Mar 2022 00:37:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3A93768B0A2; Wed, 16 Mar 2022 02:37:29 +0200 (EET) Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1C2FC68A255 for ; Wed, 16 Mar 2022 02:37:23 +0200 (EET) Received: by mail-oi1-f175.google.com with SMTP id q189so1046660oia.9 for ; Tue, 15 Mar 2022 17:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=Mbtu4tJofIDJeY25b4/dUPWwWmze+0MWcct4jfMSkjY=; b=HHkHjmbvsh51jthEU9cMQn9gTG7N0hYybx4fj7v7dF484bze4Dd1XssbWCuPoBFdW6 ukEmvjEzRh84kNNToTeqHdJx6uPfl+UTy21pm4eLBzvHwgFuB4TnLWLbf3Cir7KHZVuy QSaJtXDPo3EjitUZ4nI7id83jELWgXUYing5xxBSt5PtZqEMppeRqrwuLr38+1mksdP3 WQYuV1gWpg7lb1hwV740A3eJ65ByFOliPYoUtCr3VpczRzk5H6muMGH/ZmP9utJGqc4Q fcbjjMt+XsWU6uipmAOwDrwjuNwcl/Fo5qc6Gy2zG+VUPxhyzX2TVEl8pkDleqI+Xfcr F05g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Mbtu4tJofIDJeY25b4/dUPWwWmze+0MWcct4jfMSkjY=; b=HN3N1/nWNGK1cdhNv0rE43jJq7Fw/If7ZPaQWjrHA4zlvEw2rgDYxYtmT90qZFcjV7 PXYQvLnJOEVTZMG9ZV5tbO/rcASKKXatuhZx1mFanWka1sxsM0T3eywr+96vN97cfkzS kUMXbLHZO1LzgtB1J8Fu5PlzyDWWU3+AUGm8yO3zopDs6N4W9Ysl9eeNrBX8vO+/oIim eFGYD3deP31TZvsjBVDi+8LlET5ieRjuzPPdLMEJoVhNhWChl+mgRedFutT3ileEqnu/ GE6aUdCYx3LAhbXuc9faS9EgjiFjwRwHsuGsHKBUAqREm7IwudvRJMZmRv4NcC37yTTx 9z7g== X-Gm-Message-State: AOAM530elqhiseKuORHfzdHSs6/7GDAQuC/dlfBcCr0dDnMQTg1NkKho 3v0NY7qy7WbjIazh48zPRWnbRP9WjPf1hQ== X-Google-Smtp-Source: ABdhPJyElHq40CobEZ3VKnnrgSG7tf4S/Ts2gK5l+CUZDuCYUN2srq+VpcDpDkRbn+I2viz+TCbE+w== X-Received: by 2002:a05:6808:1249:b0:2d4:13f1:8508 with SMTP id o9-20020a056808124900b002d413f18508mr2951351oiv.82.1647391041168; Tue, 15 Mar 2022 17:37:21 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id k4-20020a9d4b84000000b005b2310ebdffsm236596otf.54.2022.03.15.17.37.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Mar 2022 17:37:20 -0700 (PDT) Message-ID: Date: Tue, 15 Mar 2022 21:37:19 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220315223444.3449-1-michael@niedermayer.cc> <20220316003319.GG2829255@pb2> From: James Almer In-Reply-To: <20220316003319.GG2829255@pb2> Subject: Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Fix build failure from channels API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/15/2022 9:33 PM, Michael Niedermayer wrote: > On Tue, Mar 15, 2022 at 07:45:36PM -0300, James Almer wrote: >> On 3/15/2022 7:34 PM, Michael Niedermayer wrote: >>> Regression since 2f8ccca2fa94ce256ff77baa18f462c1abd8d2cc and surrounding commits >>> >>> Signed-off-by: Michael Niedermayer >>> --- >>> tools/target_dec_fuzzer.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c >>> index eaa26b0e62..3bd1eff3ce 100644 >>> --- a/tools/target_dec_fuzzer.c >>> +++ b/tools/target_dec_fuzzer.c >>> @@ -47,6 +47,7 @@ >>> #include "config.h" >>> #include "libavutil/avassert.h" >>> +#include "libavutil/avstring.h" >> >> Why? > > av_strlcatf() IIRC Seems unrelated, but ok. > >> >>> #include "libavutil/cpu.h" >>> #include "libavutil/imgutils.h" >>> #include "libavutil/intreadwrite.h" >>> @@ -273,7 +274,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { >>> extradata_size = bytestream2_get_le32(&gbc); >>> ctx->sample_rate = bytestream2_get_le32(&gbc) & 0x7FFFFFFF; >>> - ctx->ch_layout.channels = (unsigned)bytestream2_get_le32(&gbc) % FF_SANE_NB_CHANNELS; >>> + ctx->ch_layout.nb_channels = (unsigned)bytestream2_get_le32(&gbc) % FF_SANE_NB_CHANNELS; >> >> LGTM, sorry about the breakage. > > will apply tomorrow, feel free to apply before > > thx Applied. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".