From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 49E23489DD for ; Fri, 22 Dec 2023 12:35:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 84E7D68D2FF; Fri, 22 Dec 2023 14:35:53 +0200 (EET) Received: from s.wfbtzhsw.outbound-mail.sendgrid.net (unknown [159.183.224.105]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DC25068D2CB for ; Fri, 22 Dec 2023 14:35:46 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=frankplowman.com; h=mime-version:subject:references:from:in-reply-to:to:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=NdeFHl3jRWx8zZXby0x7kvKotaPOb8x5fDBKNMIqVe0=; b=hC8dw2L2oL/adx90zFQtn6Tx7DnBPhkkKg8rRR8rgkN0407uoNBs36dKOyvpcEXkn+ej VlYNxe8/AU9DNdl9HEwNISlyrMDmWJCy3x2sHSauHEu3mm1fEYB4Z6EmtAKu4R3FXXug7J 9+BDqiZy4bKLiZw+udPq7jm28lo9MD0Y5tMYk41irTsKlrRrxCwx0R4FZakWpjt78m8tRQ ZzygyfAcAgp9ndx7/QJcl+pF50xd5j4yRFK8KmX9WRhxHeGOaiwwyh+fCI8Z7aH9Si/Gle 5c0SzhK9+JVY2SsVLVBnq138i6vxR5t92gtAQ9NYHQH+CfNc2zwUEE8l7PnotNFQ== Received: by filterdrecv-655bd866f5-9t24g with SMTP id filterdrecv-655bd866f5-9t24g-1-658582A1-7 2023-12-22 12:35:45.225540204 +0000 UTC m=+937950.709591200 Received: from [10.0.0.6] (unknown) by geopod-ismtpd-10 (SG) with ESMTP id db2v9FZ1Sl6GP9rTi5m_Rg for ; Fri, 22 Dec 2023 12:35:44.946 +0000 (UTC) Message-ID: Date: Fri, 22 Dec 2023 12:35:45 +0000 (UTC) MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB References: <20231222115959.362902-1-post@frankplowman.com> From: Frank Plowman In-Reply-To: X-SG-EID: =?us-ascii?Q?Uj3aYg52c+LLQjRSx2kNrre9PZxeM4UYymiuV7D=2FDFCrUPtmdddVVDUZk3miaV?= =?us-ascii?Q?h1=2FJO1FFHK2V1NQv9+VwRIHD4uj8HQ1MDmyFki2?= =?us-ascii?Q?41NYnTsRScatYrPJ16FHEGvVCNhsSkfy08g8dXX?= =?us-ascii?Q?rqI45aFIATplkK1dFpGupnpF4rwrUXVQA01ErFO?= =?us-ascii?Q?=2FjVOfovaTbimX1etlh5QEq3JeV6erir9Nenczyy?= =?us-ascii?Q?HgVxvd2WewFFDSBxVy9hXOgVoXeS6Syw=2FGiLF3?= To: ffmpeg-devel@ffmpeg.org X-Entity-ID: LpPALsXh5JN/Quf2dstifQ== Subject: Re: [FFmpeg-devel] [PATCH] avformat/ffrtmpcrypt: Fix int-conversion warning X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi Martin, Thanks for the review. On 22/12/2023 12:15, Martin Storsj=F6 wrote: > The change LGTM, but the wording here is slightly confusing IMO. The = > problem isn't with using per se AVERROR, that's just a macro for = > generating suitable integers, the issue is more about the fact that = > we're returning from a macro, without knowing the actual context where = > the macro is invoked. > > WDYT about this wording? > >> The gcrypt definition of `bn_new` used to use the return statement on = >> errors, with an AVERROR return value, regardless of the signature of = >> the function where the macro is used - it is called in = >> `dh_generate_key` and `ff_dh_init` which return pointers. As a = >> result, compiling with gcrypt and the ffrtmpcrypt protocol resulted = >> in an int-conversion warning. GCC 14 may upgrade these to errors [1]. Yeah this is better, I agree. Cheers, Frank -- = https://www.frankplowman.com/ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".