Re: [FFmpeg-devel] [PATCH] avformat/ffrtmpcrypt: Fix int-conversion warning

From: Frank Plowman <post@frankplowman.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/ffrtmpcrypt: Fix int-conversion warning
Date: Fri, 22 Dec 2023 12:35:45 +0000 (UTC)
Message-ID: <f2dfc8d9-8773-4e72-8d49-98d8048f6bb0@frankplowman.com> (raw)
In-Reply-To: <e1856a6a-95b5-609d-a22-ec567af2c02d@martin.st>

Hi Martin,

Thanks for the review.

On 22/12/2023 12:15, Martin Storsjö wrote:
> The change LGTM, but the wording here is slightly confusing IMO. The 
> problem isn't with using per se AVERROR, that's just a macro for 
> generating suitable integers, the issue is more about the fact that 
> we're returning from a macro, without knowing the actual context where 
> the macro is invoked.
>
> WDYT about this wording?
>
>> The gcrypt definition of `bn_new` used to use the return statement on 
>> errors, with an AVERROR return value, regardless of the signature of 
>> the function where the macro is used - it is called in 
>> `dh_generate_key` and `ff_dh_init` which return pointers. As a 
>> result, compiling with gcrypt and the ffrtmpcrypt protocol resulted 
>> in an int-conversion warning. GCC 14 may upgrade these to errors [1].

Yeah this is better, I agree.

Cheers,
Frank

-- 
https://www.frankplowman.com/

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".