Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda
Date: Mon, 25 Sep 2023 18:09:57 +0200
Message-ID: <f2c37793-33a1-4035-828e-db5782445c0e@rothenpieler.org> (raw)
In-Reply-To: <CALbjROKfXHYa-25xGdDdPhBNvmiDt7U+_Cd1DK=AjmdKc1hnEg@mail.gmail.com>

On 25.09.2023 14:18, Kyle Swanson wrote:
> Hi,
> 
> On Sat, Sep 23, 2023 at 12:02 PM Timo Rothenpieler <timo@rothenpieler.org>
> wrote:
> 
>> On 23.09.2023 11:50, Kyle Swanson wrote:
>>> Hi,
>>>
>>> On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler <
>> timo@rothenpieler.org>
>>> wrote:
>>>> Or it needs to be a sub-feature of libvmaf, where if libvmaf is enabled,
>>>> support for CUDA is checked for, and then the vmaf_cuda filter needs to
>>>> depend on that check.
>>>
>>> This previous patch should do just that [0]. What's missing?
>>
>> The checks in there seem both overly complex and also not correct to me.
>> I've never seen a "*_filter" in a check_pkg_config or similar call.
>> With this setup, it'd be possible to call configure with
>> --enable-libvmaf, and have it success, even though there is no libvmaf
>> on the system, as long as the filter is disabled.
>>
>> If you want to go the implicit route, you'll want the following two things:
>>
>> For the dependencies
>>
>>   > libvmaf_cuda_filter_deps="libvmaf libvmaf_cuda ffnvcodec"
>>
>> And then at some point after the current "require_pkg_config libvmaf"
>> check:
>>
>>> enabled libvmaf && check_pkg_config libvmaf_cuda "libvmaf >= 2.0.0"
>> libvmaf_cuda.h vmaf_cuda_state_init
>>
>> I think there's a place in configure where a bunch of such optional
>> checks happen.
>> But I see no issue with throwing it right after the current libvmaf
>> check either.
>>
> 
> New patch attached.

lgtm

> Thanks,
> Kyle
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-09-25 16:10 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07 17:50 Kyle Swanson
2023-08-14 16:29 ` Kyle Swanson
2023-08-14 17:09 ` Timo Rothenpieler
2023-08-23 20:39   ` Kyle Swanson
2023-08-28 18:54     ` Kyle Swanson
2023-08-28 18:59       ` Timo Rothenpieler
2023-08-28 20:16         ` Kyle Swanson
2023-08-29 17:09           ` Kyle Swanson
2023-08-29 22:14             ` Andreas Rheinhardt
2023-08-30 16:44               ` Kyle Swanson
2023-08-31 18:39                 ` Kyle Swanson
2023-09-05 17:16                   ` Kyle Swanson
2023-09-11 17:53                     ` Kyle Swanson
2023-09-11 18:51                       ` Timo Rothenpieler
2023-09-14 18:59                         ` Kyle Swanson
2023-09-14 19:10                           ` Timo Rothenpieler
2023-09-15 20:31                             ` Kyle Swanson
2023-09-15 22:33                               ` Timo Rothenpieler
2023-09-18 16:42                                 ` Kyle Swanson
2023-09-18 19:21                                   ` Marvin Scholz
2023-09-18 19:41                                     ` Timo Rothenpieler
2023-09-18 21:39                                       ` Kyle Swanson
2023-09-20 20:06                                         ` Kyle Swanson
2023-09-20 22:54                                           ` Timo Rothenpieler
2023-09-23  9:50                                             ` Kyle Swanson
2023-09-23 11:02                                               ` Timo Rothenpieler
2023-09-25 12:18                                                 ` Kyle Swanson
2023-09-25 16:09                                                   ` Timo Rothenpieler [this message]
2023-09-27 17:26                                                     ` Kyle Swanson
2023-08-28 19:05       ` Paul B Mahol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2c37793-33a1-4035-828e-db5782445c0e@rothenpieler.org \
    --to=timo@rothenpieler.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git