From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 635914559D for ; Sat, 4 Nov 2023 13:53:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B8FAF68CE52; Sat, 4 Nov 2023 15:53:24 +0200 (EET) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AE98D68CE52 for ; Sat, 4 Nov 2023 15:53:18 +0200 (EET) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-5afabb23900so35766077b3.2 for ; Sat, 04 Nov 2023 06:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699105996; x=1699710796; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yrXjRmFZLACzxJb5coIFsdffcqIGy+u5mTWQjEi04sY=; b=avdbQREcuZEfMOCSWC60AECNuNzIWuPytBre5dW2j9Uh2ji3ki8NrbhBGOeNaAT//8 QwqbDW8++JtAZppXD9soiv1oko5f9Q+HC9A+mmUpLq0zSNDemTsFgFMUZXAuD27/lzgJ UTTs1/nunVK+eF7p3y9FUhER7SzxvGyrGnwQH0qPjCm9/Ljm8UC02oaWlw1VJ8nNmk2i YRFFGW0RJUGkyshZsGOnVpl0V68N427d++hXOMtgLd55XgIEZAY9LSe0vxFTqfflnq8B pyggEs6f13cQWPWwxlPd4dkGeqBieBYqqKqaT3mShZSPTVYoPnBE65bw+9U/LKyTp+68 od2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699105996; x=1699710796; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yrXjRmFZLACzxJb5coIFsdffcqIGy+u5mTWQjEi04sY=; b=g2DcXQYv/O+u7VWmZbMKFpHfoWMOTFeo4QnFd1SlIttkt22mGZlmxvYgjvMWvFv9GL exojCobVkg1qndnELh9Vnmwsla0gmks086MvBkqEF3Er6fitUBChS5Cp9NytuJaOjWo1 e0962kcK9HgCRNzXnzBXLpv4hJ/hURDNDAH7p6D4ki9HB7FFCwOF8e82BnBfFfm+Gdek iPr7GJjVllaisk/If4qx8Nvn1F1REQPRpwptbqnq/PNzuroXYRDjjxkNZMrvup7TG17c MTqY7rlAvwCWzPdlYbSRW6HapOtluoUT+j3vqXoEUmi2lDNF/oBUhZC4co98DVf6jmT8 F0mw== X-Gm-Message-State: AOJu0Yx50g4EeHHRL9rYnnI6AGt80bVhhy0tjPa9g+d3EWB2NL8Rcg+L a2COluhMcbyV3aQhVvfl4zVcIQr3TsM= X-Google-Smtp-Source: AGHT+IGpXKY8U0zzoJ3RS5HxuKlocPA9FgRsdWCiVJ6PBl2cYXxwnIiWP4LuujhA0AoK6Mq8HGPOIA== X-Received: by 2002:a81:6dd4:0:b0:5a7:fbd5:8b3 with SMTP id i203-20020a816dd4000000b005a7fbd508b3mr5927902ywc.10.1699105996341; Sat, 04 Nov 2023 06:53:16 -0700 (PDT) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id o63-20020a0dfe42000000b005463e45458bsm2081574ywf.123.2023.11.04.06.53.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Nov 2023 06:53:15 -0700 (PDT) Message-ID: Date: Sat, 4 Nov 2023 10:53:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20231104092125.10213-1-anton@khirnov.net> <20231104092125.10213-19-anton@khirnov.net> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <20231104092125.10213-19-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 18/24] fftools/ffmpeg: add thread-aware transcode scheduling infrastructure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/4/2023 4:56 AM, Anton Khirnov wrote: > +static void *task_wrapper(void *arg) > +{ > + SchTask *task = arg; > + Scheduler *sch = task->parent; > + int ret; > + int err = 0; > + > + ret = (intptr_t)task->func(task->func_arg); > + if (ret < 0) > + av_log(task->func_arg, AV_LOG_ERROR, > + "Task finished with error code: %d (%s)\n", ret, av_err2str(ret)); > + > + switch (task->node.type) { > + case SCH_NODE_TYPE_DEMUX: err = demux_done (sch, task->node.idx); break; > + case SCH_NODE_TYPE_MUX: err = mux_done (sch, task->node.idx); break; > + case SCH_NODE_TYPE_DEC: err = dec_done (sch, task->node.idx); break; > + case SCH_NODE_TYPE_ENC: err = enc_done (sch, task->node.idx); break; > + case SCH_NODE_TYPE_FILTER_IN: err = filter_done(sch, task->node.idx); break; task->node.type seems to be constant, so wouldn't it be faster, or at least cleaner looking here, to use a function pointer assigned in task_init()? > + default: av_assert0(0); > + } > + > + ret = err_merge(ret, err); > + > + // EOF is considered normal termination > + if (ret == AVERROR_EOF) > + ret = 0; > + if (ret < 0) > + atomic_store(&sch->task_failed, 1); > + > + av_log(task->func_arg, ret < 0 ? AV_LOG_ERROR : AV_LOG_VERBOSE, > + "Terminating thread with return code %d (%s)\n", ret, > + ret < 0 ? av_err2str(ret) : "success"); > + > + return (void*)(intptr_t)ret; > +} _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".