[FFmpeg-devel] [PATCH] aarch64: Only emit the PAC/BTI note section when targeting ELF

[FFmpeg-devel] [PATCH] aarch64: Only emit the PAC/BTI note section when targeting ELF

[Martin Storsjö]

This avoids build errors if such features are enabled while targeting
another binary format. (Using such features on other platforms
might require some other form of signaling/setup though, but
the ELF specific .note section isn't applicable at least.)

Signed-off-by: Martin Storsjö <martin@martin.st>
---
 libavutil/aarch64/asm.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavutil/aarch64/asm.S b/libavutil/aarch64/asm.S
index b817eaab22..a7782415d7 100644
--- a/libavutil/aarch64/asm.S
+++ b/libavutil/aarch64/asm.S
@@ -141,7 +141,7 @@
 #endif
 
 
-#if (GNU_PROPERTY_AARCH64_BTI != 0 || GNU_PROPERTY_AARCH64_PAC != 0)
+#if (GNU_PROPERTY_AARCH64_BTI != 0 || GNU_PROPERTY_AARCH64_PAC != 0) && defined(__ELF__)
         .pushsection .note.gnu.property, "a"
         .balign 8
         .long 4
-- 
2.32.0 (Apple Git-132)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] aarch64: Only emit the PAC/BTI note section when targeting ELF

[Martin Storsjö]

On Wed, 9 Mar 2022, Martin Storsjö wrote:

> This avoids build errors if such features are enabled while targeting
> another binary format. (Using such features on other platforms
> might require some other form of signaling/setup though, but
> the ELF specific .note section isn't applicable at least.)
>
> Signed-off-by: Martin Storsjö <martin@martin.st>
> ---
> libavutil/aarch64/asm.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/aarch64/asm.S b/libavutil/aarch64/asm.S
> index b817eaab22..a7782415d7 100644
> --- a/libavutil/aarch64/asm.S
> +++ b/libavutil/aarch64/asm.S
> @@ -141,7 +141,7 @@
> #endif
>
>
> -#if (GNU_PROPERTY_AARCH64_BTI != 0 || GNU_PROPERTY_AARCH64_PAC != 0)
> +#if (GNU_PROPERTY_AARCH64_BTI != 0 || GNU_PROPERTY_AARCH64_PAC != 0) && defined(__ELF__)
>         .pushsection .note.gnu.property, "a"
>         .balign 8
>         .long 4
> -- 
> 2.32.0 (Apple Git-132)

Pushed.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".