From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id EC39A46834
	for <ffmpegdev@gitmailbox.com>; Thu, 20 Jul 2023 20:47:56 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B3FAF68C5BE;
	Thu, 20 Jul 2023 23:47:53 +0300 (EEST)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1A24C68C33E
 for <ffmpeg-devel@ffmpeg.org>; Thu, 20 Jul 2023 23:47:47 +0300 (EEST)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 36KKlk9G014360-36KKlk9H014360;
 Thu, 20 Jul 2023 23:47:46 +0300
Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144])
 by mail9.parnet.fi (Postfix) with ESMTPS id E2DA1A1428;
 Thu, 20 Jul 2023 23:47:45 +0300 (EEST)
Date: Thu, 20 Jul 2023 23:47:45 +0300 (EEST)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <20230720170108.2854-1-timo@rothenpieler.org>
Message-ID: <f189a9-3af0-8811-c431-7d3c36faba15@martin.st>
References: <20230720170108.2854-1-timo@rothenpieler.org>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: forward rw_timeout
 to tcp proto
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Timo Rothenpieler <timo@rothenpieler.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/f189a9-3af0-8811-c431-7d3c36faba15@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Thu, 20 Jul 2023, Timo Rothenpieler wrote:

> ---
> libavformat/rtmpproto.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)

Hmm, I would have somewhat expected that rw_timeout should be honored here 
already...

Note that URLContext already has got a rw_timeout field and AVOption, so 
instead of adding a new option, it should be enough to just use the 
existing URLContext field.

But also, have a look at fab8156b2f30666adabe227b3d7712fd193873b1. When 
opening a chained URLContext, we pass in the parent one, and propagate any 
options from that URLContext into the child. So as long as the URLContext 
rw_timeout is set for the rtmp protocol, the nested tcp protocol also 
should be getting it already implicitly.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".