From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Timo Rothenpieler <timo@rothenpieler.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: forward rw_timeout to tcp proto
Date: Thu, 20 Jul 2023 23:47:45 +0300 (EEST)
Message-ID: <f189a9-3af0-8811-c431-7d3c36faba15@martin.st> (raw)
In-Reply-To: <20230720170108.2854-1-timo@rothenpieler.org>
On Thu, 20 Jul 2023, Timo Rothenpieler wrote:
> ---
> libavformat/rtmpproto.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Hmm, I would have somewhat expected that rw_timeout should be honored here
already...
Note that URLContext already has got a rw_timeout field and AVOption, so
instead of adding a new option, it should be enough to just use the
existing URLContext field.
But also, have a look at fab8156b2f30666adabe227b3d7712fd193873b1. When
opening a chained URLContext, we pass in the parent one, and propagate any
options from that URLContext into the child. So as long as the URLContext
rw_timeout is set for the rtmp protocol, the nested tcp protocol also
should be getting it already implicitly.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-20 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 17:01 Timo Rothenpieler
2023-07-20 20:47 ` Martin Storsjö [this message]
2023-07-20 20:57 ` Timo Rothenpieler
2023-07-20 21:09 ` Martin Storsjö
2023-07-20 21:29 ` Timo Rothenpieler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f189a9-3af0-8811-c431-7d3c36faba15@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=timo@rothenpieler.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git