From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 37FA9472E6 for ; Mon, 4 Sep 2023 16:10:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 93A4C68C6E5; Mon, 4 Sep 2023 19:10:56 +0300 (EEST) Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B528668BF6B for ; Mon, 4 Sep 2023 19:10:49 +0300 (EEST) Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-573249e73f8so1155600eaf.1 for ; Mon, 04 Sep 2023 09:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693843848; x=1694448648; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e58+lEpLrrR3SbJcGJxlODM5jCWbcVEKpobdw9e/Gwk=; b=fncap6sZZkUK7iDRRpQPiikjY1hlF7rPg2mE90jL/X7ewOTwzUs1a+CvxX75HQkuQq pMdskVvqPPFBB0GvEptCMqViy55wnlj7sSf967GQC3MifVbOpouOpJktW1R5k1M8SKSk wCHAmForL8eS7tQNjvXLAasqycx2VClxcLTS0plDFpCxHAAqgNsOiOzkgJw3c+7G+if8 quxMETiO/VB7jsR8GCRLtPGiknxd7PGUmFv/GhWxtoG0ZC47m7L73dOTTi1jpofWVgeZ gCy4EK7Ajff+k19zJdWCDod5ATY/cYyyvL8e2MZG6XGKLTzxbwl6GLT3j1yv5nrQu1jR r0Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693843848; x=1694448648; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e58+lEpLrrR3SbJcGJxlODM5jCWbcVEKpobdw9e/Gwk=; b=g6duEKAMuYX4mUmzRuPUDUQlTrWp1sUDZOpZRqGZj0hjYGswuu19M5YFhLzAvW8iqr EMNF2L+4ZxQ2Xt8VhgJ0ut2BIC0l/mzCqe1HvDPFjP37fuTOqSqhN8O7p53QlXWK7ry6 PpzP+dNp2QjgVJesoMEP+Xxf3wDeOdmF5s2x0TtKeajAqvadjbxkZpujo18LaqaBaS38 Jk46VrVZrUsj4E7lLs/ZDbRDvrq10J8fZkD7YpOrToP5gkxXueThQMo/yhUuFTHxG9z8 9RldCNxDfU/zDy0QnHhjWi6vRIfPfeiHZ8yF1b0rPy+hjGtAXCgztCk/TTxPD2ivTpgs 3B0Q== X-Gm-Message-State: AOJu0Yzx/G3pRegjWBXD/uiLjBlakTTegEsxoHVx06JoFO67GjJfyFGp X5RQXsD3kEBKk5xBi93OQbftjGKLCzs= X-Google-Smtp-Source: AGHT+IF2h6DXm7iof2b38GiBUMqo1F27jl/ytwM6TC9vqXglImE5k96syhaSniGAmJdufesa3TpnJQ== X-Received: by 2002:a05:6820:284:b0:573:397d:84f7 with SMTP id q4-20020a056820028400b00573397d84f7mr9381915ood.4.1693843847817; Mon, 04 Sep 2023 09:10:47 -0700 (PDT) Received: from [192.168.0.10] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id 68-20020a4a1d47000000b00570bc62a8d4sm5099282oog.29.2023.09.04.09.10.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Sep 2023 09:10:47 -0700 (PDT) Message-ID: Date: Mon, 4 Sep 2023 13:10:52 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230904150411.56777-1-jamrial@gmail.com> <7d9e4055-c77c-38e5-6e92-58a0eaff5e46@gmail.com> From: James Almer In-Reply-To: <7d9e4055-c77c-38e5-6e92-58a0eaff5e46@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 00/17 v3] AVCodecContext and AVCodecParameters side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/4/2023 12:37 PM, Derek Buitenhuis wrote: > On 9/4/2023 4:03 PM, James Almer wrote: >> 71 files changed, 737 insertions(+), 415 deletions(-) > > I see no document updates, commit messages, or deprecation warnings > that would: > > * Explain what and why this is happening - this should at the very > least be in the commit message(s), if not a doc somewhere. IRC or > pevious ML threads are not sufficient. I'll mention it in a commit message. The idea is to properly propagate and make available the global side data in AVCodecContext, and no longer have to inject it in the first packet. This way global and frame specific side data is separate, and there's no need to copy and inject entries in several different places. The new struct allows the simple use of a single set of helpers that don't depend on the context containing the side data. > * Warn users they need to update their code to not use stream side data (?). > Will my code just silently change behavior if it was using stream > side data? I legitimately do not know due to the above. How so? This, like any other deprecated field, remains working as it always did until it's removed. The downstream users will see the deprecation warning during compilation, and the doxy for the field mentions the direct replacement. It's standard procedure. I'll add a @deprecated comment to the doxy of av_format_inject_global_side_data() to mention the aforementioned objective. > * Any useful doxy for API users or any example aside from function args and > very basic struct info. The helper functions are basically the same as the packet ones, and the stream ones I'm deprecating. add(), new(), get(), etc. Example usage as usual is in ffmpeg.c, but i think the doxy does a good job explaining what they do. > > I make no comment on the usefulness or utility of the change, but it is these > sorts of things that make downstream API users experiences a little worse. > > - Derek > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".