From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7936243BED for ; Sun, 20 Nov 2022 17:45:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 929A768BB4C; Sun, 20 Nov 2022 19:44:58 +0200 (EET) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1503068B83A for ; Sun, 20 Nov 2022 19:44:52 +0200 (EET) Received: by mail-ot1-f54.google.com with SMTP id db10-20020a0568306b0a00b0066d43e80118so6148885otb.1 for ; Sun, 20 Nov 2022 09:44:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KFY88fYh3/VBYuGNwq6zKGtCAWRfAXrZLEoqSK3TgvA=; b=MOScJQg5axrZvk9nSLLYvZLmpoet1Ye1NL5Aouo9QrrkHUhJii7AiQGJ+1HO0Epxyq 5lQeUlBb5er+QwnbTO76DwSZvElX5zsPIKXWFwMIy5u+zqhK568IhM+H/u/SbmYCnnPB uDEq8IyBPhD1J8tgvLo96RsVQEdxjeeSTAZfXj9QLZ0PA4RK0p+o0sb8Zqh8h3c2Xoq2 m/OKXPxAmSO3Lg2AYMK7n1HwNRL57iTuKIrP0GdG+w8uutU/0mCWEFRDka59EbTiGPQw 14aRcF26k5RSxlg3ZgweZZgnI1NbbpM5LY3XN1rKETSXNBOFxtWHEQsNtbPo7z29Zhm4 Otwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KFY88fYh3/VBYuGNwq6zKGtCAWRfAXrZLEoqSK3TgvA=; b=ifCq9Bnf6bhkEVkUrU5l5yM1PmY4TP9e29rKkCB5I77SLrOtxJRhNSHr49gNWPVyog T+s5bv8kvsNfXUc/01KXlPbAZSCnbjbO3DRC4V3yLH0QthyOqnhu5x6p574IY0gmvljh 936nZkr7Xu/F7xGccqpPtJ4fGTZJR14q4HyhA712TJDNKCertFzRI0YUf+P1k6JXsU7l Rdipx6W/9JdpUb01qiXA9a/e675JKBwNinNHtx+fje6mFYyIb0AhQVYjaefJjvZuxdiz ddCjAAZ/oVRZuqnZTuWtPRYGMKT9uRUlC3hJUFT4wACDx1DPiXjoUVGjzj8Oxp1ht9V8 DruA== X-Gm-Message-State: ANoB5pl/0G7Z4VeEoyUwxT31NX+EmOwc5K36ux/L2gcvelvCkiSuyHp4 Ima/dl68O4VMONCLOXvkqBtHpBNmpoI= X-Google-Smtp-Source: AA0mqf7DkgI8VRgDYy4FeiG3mfg87kDTnlLsXH60wI1/3iv+FKkDiofcInrdl6Afc8Aizf/5443RpQ== X-Received: by 2002:a9d:4f07:0:b0:662:c31:161c with SMTP id d7-20020a9d4f07000000b006620c31161cmr1472078otl.301.1668966289820; Sun, 20 Nov 2022 09:44:49 -0800 (PST) Received: from [192.168.0.15] ([181.85.72.69]) by smtp.gmail.com with ESMTPSA id b2-20020aca2202000000b0034d9042758fsm3384458oic.24.2022.11.20.09.44.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Nov 2022 09:44:49 -0800 (PST) Message-ID: Date: Sun, 20 Nov 2022 14:45:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20221120170625.3578-1-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avfilter/framepool: use aligned height when allocating plane buffers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/20/2022 2:40 PM, Paul B Mahol wrote: > On 11/20/22, James Almer wrote: >> Fixes tickets #10051 and #10052. >> > > Not real fix, more like big hack. This is in line with other frame pools like the lavc one. If you know a better fix, then please send a patch. > >> Signed-off-by: James Almer >> --- >> libavfilter/framepool.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c >> index 0404589055..7e830c5a3b 100644 >> --- a/libavfilter/framepool.c >> +++ b/libavfilter/framepool.c >> @@ -91,15 +91,13 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* >> (*alloc)(size_t size), >> linesizes[i] = pool->linesize[i]; >> >> if (av_image_fill_plane_sizes(sizes, pool->format, >> - pool->height, >> + FFALIGN(pool->height, align), >> linesizes) < 0) { >> goto fail; >> } >> >> for (i = 0; i < 4 && sizes[i]; i++) { >> - if (sizes[i] > SIZE_MAX - align) >> - goto fail; >> - pool->pools[i] = av_buffer_pool_init(sizes[i] + align, alloc); >> + pool->pools[i] = av_buffer_pool_init(sizes[i], alloc); >> if (!pool->pools[i]) >> goto fail; >> } >> -- >> 2.38.1 >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".