[FFmpeg-devel] [QUESTION] Regarding my first patch submission: "filters: add separator line to show_filters output"

[FFmpeg-devel] [QUESTION] Regarding my first patch submission: "filters: add separator line to show_filters output"

[张洪源 via ffmpeg-devel]

[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]

Dear FFmpeg Developers and Maintainers,

I hope this email finds you well.


My name is [Your Name], and I am writing to kindly inquire about a patch I recently submitted as my first contribution to the FFmpeg project. The patch is titled:


"[PATCH] fftools/opt_common: add separator line to show_filters output"


I submitted this patch via email on [Date of Submission], but I have been unable to locate it in the mailing list archives at https://ffmpeg.org/pipermail/ffmpeg-devel/.


As this is my first time contributing to FFmpeg, I am concerned that there might be an issue with my submission method or the patch format. I would be very grateful if you could help me verify:


Whether the patch was received successfully by the mailing list


Whether the patch format meets the project's requirements


If there are any issues with the submission, what I should do to correct them


The patch is attached again to this email for your reference. I have followed the contributing guidelines to the best of my understanding, but I want to make sure everything is correct.


Thank you very much for your time and guidance. I truly appreciate your work on FFmpeg and would be honored to contribute to this project.



        Best regards,

Zhang hongyaun
zhanghongyuan@uniontech.com

[-- Attachment #2: [PATCH] fftools_opt_common_ add separator line to show_filters output.eml --]
[-- Type: application/octet-stream, Size: 1784 bytes --]

X-QQ-mid: zesmtpsz3t1756801046tc080d6a5
X-QQ-Originating-IP: YXZ6JYiXqn4AO/GEnAyFAKz86igKIgZOVOQnYZ7dXiY=
Received: from localhost.localdomain ( [110.191.179.216])
	by bizesmtp.qq.com (ESMTP) with 
	id ; Tue, 02 Sep 2025 16:17:14 +0800 (CST)
X-QQ-SSF: 0000000000000000000000000000000
X-QQ-GoodBg: 0
X-BIZMAIL-ID: 5052788487051432931
EX-QQ-RecipientCnt: 2
From: zhanghongyuan <zhanghongyuan@uniontech.com>
To: ffmpeg-devel@ffmpeg.org
Cc: zhanghongyuan <zhanghongyuan@uniontech.com>
Subject: [PATCH] fftools/opt_common: add separator line to show_filters output
Date: Tue,  2 Sep 2025 16:17:08 +0800
Message-Id: <20250902081708.16250-1-zhanghongyuan@uniontech.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add a separator line to show_filters() function output to maintain
consistent formatting with other show functions like show_codecs,
show_formats_devices, etc. This provides uniform formatting across
all command-line output functions for better readability and
parsing by external tools.
---
 fftools/opt_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fftools/opt_common.c b/fftools/opt_common.c
index c2f6b9de2a..5be31ffa37 100644
--- a/fftools/opt_common.c
+++ b/fftools/opt_common.c
@@ -808,7 +808,8 @@ int show_filters(void *optctx, const char *opt, const char *arg)
            "  A = Audio input/output\n"
            "  V = Video input/output\n"
            "  N = Dynamic number and/or type of input/output\n"
-           "  | = Source or sink filter\n");
+           "  | = Source or sink filter\n"
+           "  ------\n");
     while ((filter = av_filter_iterate(&opaque))) {
         descr_cur = descr;
         for (i = 0; i < 2; i++) {
-- 
2.20.1

[-- Attachment #3: Type: text/plain, Size: 163 bytes --]

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

[FFmpeg-devel] Re: [QUESTION] Regarding my first patch submission: "filters: add separator line to show_filters output"

[Timo Rothenpieler via ffmpeg-devel]

[-- Attachment #1.1: Type: text/plain, Size: 1754 bytes --]

On 9/18/2025 7:29 AM, 张洪源 via ffmpeg-devel wrote:
> Dear FFmpeg Developers and Maintainers,
> 
> I hope this email finds you well.
> 
> 
> My name is [Your Name], and I am writing to kindly inquire about a patch I recently submitted as my first contribution to the FFmpeg project. The patch is titled:
> 
> 
> "[PATCH] fftools/opt_common: add separator line to show_filters output"
> 
> 
> I submitted this patch via email on [Date of Submission], but I have been unable to locate it in the mailing list archives at https://ffmpeg.org/pipermail/ffmpeg-devel/.

That's the old mailman2 archives, that are now really only an archive, 
no new mails appear there anymore.

mailman3 has hyperkitty and public-inbox for archives.

> 
> As this is my first time contributing to FFmpeg, I am concerned that there might be an issue with my submission method or the patch format. I would be very grateful if you could help me verify:
> 
> 
> Whether the patch was received successfully by the mailing list
> 
> 
> Whether the patch format meets the project's requirements
> 
> 
> If there are any issues with the submission, what I should do to correct them
> 
> 
> The patch is attached again to this email for your reference. I have followed the contributing guidelines to the best of my understanding, but I want to make sure everything is correct.
> 
> 
> Thank you very much for your time and guidance. I truly appreciate your work on FFmpeg and would be honored to contribute to this project.

I never got such a Mail, and it's also not in the archives:
https://lists.ffmpeg.org/lore/ffmpeg-devel/?q=fftools%2Fopt_common%3A+add+separator+line+to+show_filters+output

So something has likely gone wrong with it.

[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4742 bytes --]

[-- Attachment #2: Type: text/plain, Size: 163 bytes --]

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org