From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F0D464AD7B for ; Tue, 21 May 2024 07:17:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B765268D313; Tue, 21 May 2024 10:17:08 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6720168D155 for ; Tue, 21 May 2024 10:17:02 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 24B05EA0A9 for ; Tue, 21 May 2024 09:17:02 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id is9rxKOYFAPy for ; Tue, 21 May 2024 09:16:57 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 3C512EA0A8 for ; Tue, 21 May 2024 09:16:57 +0200 (CEST) Date: Tue, 21 May 2024 09:16:57 +0200 (CEST) From: Marton Balint To: Lynne via ffmpeg-devel In-Reply-To: Message-ID: References: <20240519165444.829271-1-dev@lynne.ee> <20240519165444.829271-9-dev@lynne.ee> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: CgpPbiBTdW4sIDE5IE1heSAyMDI0LCBMeW5uZSB2aWEgZmZtcGVnLWRldmVsIHdyb3RlOgoKPiBP biAxOS8wNS8yMDI0IDIxOjM5LCBNYXJ0b24gQmFsaW50IHdyb3RlOgo+Pgo+Pgo+PiAgT24gU3Vu LCAxOSBNYXkgMjAyNCwgTHlubmUgdmlhIGZmbXBlZy1kZXZlbCB3cm90ZToKPj4KPj4+ICBUaGlz IGNvbW1pdCBhZGRzIGEgZGVjb2RlciBmb3IgdGhlIGZyZXF1ZW5jeS1kb21haW4gcGFydCBvZiBV U0FDLgo+Pj4KPj4gIFsuLi5dCj4+IAo+Pj4KPj4+ICArLyogRmluaXNoIGxhdGVyICovCj4+PiAg K3N0YXRpYyBjb25zdCBlbnVtIEFWQ2hhbm5lbCB1c2FjX2NoX3Bvc190b19hdls2NF0gPSB7Cj4+ PiAgK8KgwqDCoCBbMF0gPSBBVl9DSEFOX0ZST05UX0xFRlQsCj4+PiAgK8KgwqDCoCBbMV0gPSBB Vl9DSEFOX0ZST05UX1JJR0hULAo+Pj4gICvCoMKgwqAgWzJdID0gQVZfQ0hBTl9GUk9OVF9DRU5U RVIsCj4+PiAgK8KgwqDCoCBbM10gPSBBVl9DSEFOX0xPV19GUkVRVUVOQ1ksCj4+PiAgK8KgwqDC oCBbNF0gPSBBVl9DSEFOX0JBQ0tfTEVGVCwgLy8gdW5zdXJlCj4+PiAgK8KgwqDCoCBbNV0gPSBB Vl9DSEFOX0JBQ0tfUklHSFQsIC8vIHVuc3VyZQo+Pj4gICvCoMKgwqAgWzZdID0gQVZfQ0hBTl9G Uk9OVF9MRUZUX09GX0NFTlRFUiwKPj4+ICArwqDCoMKgIFs3XSA9IEFWX0NIQU5fRlJPTlRfUklH SFRfT0ZfQ0VOVEVSLAo+Pj4gICvCoMKgwqAgWzhdID0gMCwgLyogcmVhciBzdXJyb3VuZCBsZWZ0 IGlzIG1pc3NpbmcgKi8KPj4+ICArwqDCoMKgIFs5XSA9IDAsIC8qIHJlYXIgc3Vycm91bmQgcmln aHQgaXMgbWlzc2luZyAqLwo+Pj4gICvCoMKgwqAgWzEwXSA9IEFWX0NIQU5fQkFDS19DRU5URVIs Cj4+PiAgK8KgwqDCoCBbMTFdID0gQVZfQ0hBTl9TVVJST1VORF9ESVJFQ1RfTEVGVCwKPj4+ICAr wqDCoMKgIFsxMl0gPSBBVl9DSEFOX1NVUlJPVU5EX0RJUkVDVF9SSUdIVCwKPj4+ICArwqDCoMKg IFsxM10gPSBBVl9DSEFOX1NJREVfTEVGVCwgLy8gZmFpcmx5IHN1cmUKPj4+ICArwqDCoMKgIFsx NF0gPSBBVl9DSEFOX1NJREVfUklHSFQsIC8vIGZhaXJseSBzdXJlCj4+PiAgK8KgwqDCoCBbMTVd ID0gQVZfQ0hBTl9XSURFX0xFRlQsIC8vIHNvbWV3aGF0IGNvbmZpZGVudAo+Pj4gICvCoMKgwqAg WzE2XSA9IEFWX0NIQU5fV0lERV9SSUdIVCwgLy8gc29tZXdoYXQgY29uZmlkZW50Cj4+PiAgK8Kg wqDCoCBbMTddID0gQVZfQ0hBTl9UT1BfRlJPTlRfTEVGVCwKPj4+ICArwqDCoMKgIFsxOF0gPSBB Vl9DSEFOX1RPUF9GUk9OVF9SSUdIVCwKPj4+ICArwqDCoMKgIFsxOV0gPSBBVl9DSEFOX1RPUF9G Uk9OVF9DRU5URVIsCj4+PiAgK8KgwqDCoCBbMjBdID0gQVZfQ0hBTl9UT1BfQkFDS19MRUZULAo+ Pj4gICvCoMKgwqAgWzIxXSA9IEFWX0NIQU5fVE9QX0JBQ0tfUklHSFQsCj4+PiAgK8KgwqDCoCBb MjJdID0gQVZfQ0hBTl9UT1BfQkFDS19DRU5URVIsCj4+PiAgK8KgwqDCoCBbMjNdID0gQVZfQ0hB Tl9UT1BfU0lERV9MRUZULAo+Pj4gICvCoMKgwqAgWzI0XSA9IEFWX0NIQU5fVE9QX1NJREVfUklH SFQsCj4+PiAgK8KgwqDCoCBbMjVdID0gQVZfQ0hBTl9UT1BfQ0VOVEVSLAo+Pj4gICvCoMKgwqAg WzI2XSA9IEFWX0NIQU5fTE9XX0ZSRVFVRU5DWSwgLy8gYWN0dWFsbHkgTEZFMgo+Pj4gICvCoMKg wqAgWzI3XSA9IEFWX0NIQU5fQk9UVE9NX0ZST05UX0xFRlQsCj4+PiAgK8KgwqDCoCBbMjhdID0g QVZfQ0hBTl9CT1RUT01fRlJPTlRfUklHSFQsCj4+PiAgK8KgwqDCoCBbMjldID0gQVZfQ0hBTl9C T1RUT01fRlJPTlRfQ0VOVEVSLAo+Pj4gICvCoMKgwqAgWzMwXSA9IDAsIC8qIHRvcCBsZWZ0IHN1 cnJvdW5kIGlzIG1pc3NpbmcgKi8KPj4+ICArwqDCoMKgIFszMV0gPSAwLCAvKiB0b3AgcmlnaHQg c3Vycm91bmQgaXMgbWlzc2luZyAqLwo+Pj4gICt9Owo+Pgo+PiAgU29tZSBjb21tZW50IHdvdWxk IGJlIG5pY2UgYWJvdXQgdGhlIHNvdXJjZSBvZiB0aGlzIHRhYmxlICh3aGljaCBkb2N1bWVudCwK Pj4gIHdoaWNoIHRhYmxlKS4KPj4KPj4gIEl0IGxvb2tzIHZlcnkgc2ltaWxhciB0byB0aGUgSVNP IGNoYW5uZWwgcG9zaXRvbnMgdXNlZCBpbiBtb3ZfY2hhbi4gSQo+PiAgdGhpbmsgd2UgZm9sbG93 IHRoaXMgbWFwcGluZyBpbiBtb3N0IGNhc2VzOgo+Pgo+PiAgTGVmdMKgIFN1cnJvdW5kIGlzIFNJ REVfTEVGVAo+PiAgUmlnaHQgU3Vycm91bmQgaXMgU0lERV9SSUdIVAo+PiAgUmVhciBTdXJyb3Vu ZCBMZWZ0wqAgaXMgQkFDS19MRUZUCj4+ICBSZWFyIFN1cnJvdW5kIFJpZ2h0IGlzIEJBQ0tfUklH SFQKPj4KPj4gIFNvIGluIHlvdXIgdGFibGUgWzRdIGFuZCBbNV0gc2hvdWxkIGJlIFNJREUsIFs4 XSBhbmQgWzldIHNob3VsZCBiZSBCQUNLLgo+PiAgWzI2XSBjYW4gYmUgQVZfQ0hBTl9MT1dfRlJF UVVFTkNZXzIsIHdlIGRvIGhhdmUgdGhhdC4KPj4KPj4gIFllcywgTGVmdC9SaWdodCBTdXJyb3Vu ZCBhbmQgTGVmdC9SaWdodCBTaWRlIFN1cnJvdW5kIHdpbGwgYmUgdGhlIHNhbWUsCj4+ICBidXQg dGhvc2UgYXJlIG5vdCBwcmVzZW50IGluIGNvbW1vbmx5IHVzZWQgbGF5b3V0cyBhdCB0aGUgc2Ft ZSB0aW1lLgo+Pgo+PiAgUmVnYXJkcywKPj4gIE1hcnRvbgo+PiAgX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gIGZmbXBlZy1kZXZlbCBtYWlsaW5nIGxp c3QKPj4gIGZmbXBlZy1kZXZlbEBmZm1wZWcub3JnCj4+ICBodHRwczovL2ZmbXBlZy5vcmcvbWFp bG1hbi9saXN0aW5mby9mZm1wZWctZGV2ZWwKPj4KPj4gIFRvIHVuc3Vic2NyaWJlLCB2aXNpdCBs aW5rIGFib3ZlLCBvciBlbWFpbAo+PiAgZmZtcGVnLWRldmVsLXJlcXVlc3RAZmZtcGVnLm9yZyB3 aXRoIHN1YmplY3QgInVuc3Vic2NyaWJlIi4KPgo+IFNvdXJjZSBvZiB0aGUgdGFibGUgaXMgSVNP L0lFQyAyMzAwMy0zLCBUYWJsZSA3NCDigJQgYnNPdXRwdXRDaGFubmVsUG9zOgo+Cj4gMCBMIGxl ZnQgZnJvbnQgRkwgZnJvbnQgbGVmdAo+IDEgUiByaWdodCBmcm9udCBGUiBmcm9udCByaWdodAo+ IDIgQyBjZW50ZXIgZnJvbnQgRkMgZnJvbnQgY2VudHJlCj4gMyBMRkUgbG93IGZyZXF1ZW5jeSBl bmhhbmNlbWVudCBMRkUxIGxvdyBmcmVxdWVuY3kgZWZmZWN0cy0xCj4gNCBMcyBsZWZ0IHN1cnJv dW5kIExTIGxlZnQgc3Vycm91bmQKPiA1IFJzIHJpZ2h0IHN1cnJvdW5kIFJTIHJpZ2h0IHN1cnJv dW5kCj4gNiBMYyBsZWZ0IGZyb250IGNlbnRlciBGTGMgZnJvbnQgbGVmdCBjZW50cmUKPiA3IFJj IHJpZ2h0IGZyb250IGNlbnRlciBGUmMgZnJvbnQgcmlnaHQgY2VudHJlCj4gOCBMc3IgcmVhciBz dXJyb3VuZCBsZWZ0IEJMIGJhY2sgbGVmdAo+IDkgUnNyIHJlYXIgc3Vycm91bmQgcmlnaHQgQlIg YmFjayByaWdodAo+IDEwIENzIHJlYXIgY2VudGVyIEJDIGJhY2sgY2VudHJlCj4gMTEgTHNkIGxl ZnQgc3Vycm91bmQgZGlyZWN0IExTZCBsZWZ0IHN1cnJvdW5kIGRpcmVjdAo+IDEyIFJzZCByaWdo dCBzdXJyb3VuZCBkaXJlY3QgUlNkIHJpZ2h0IHN1cnJvdW5kIGRpcmVjdAo+IDEzIExzcyBsZWZ0 IHNpZGUgc3Vycm91bmQgU0wgc2lkZSBsZWZ0Cj4gMTQgUnNzIHJpZ2h0IHNpZGUgc3Vycm91bmQg U1Igc2lkZSByaWdodAo+IDE1IEx3IGxlZnQgd2lkZSBmcm9udCBGTHcgZnJvbnQgbGVmdCB3aWRl Cj4gMTYgUncgcmlnaHQgd2lkZSBmcm9udCBGUncgZnJvbnQgcmlnaHQgd2lkZQo+IDE3IEx2IGxl ZnQgZnJvbnQgdmVydGljYWwgaGVpZ2h0IFRwRkwgdG9wIGZyb250IGxlZnQKPiAxOCBSdiByaWdo dCBmcm9udCB2ZXJ0aWNhbCBoZWlnaHQgVHBGUiB0b3AgZnJvbnQgcmlnaHQKPiAxOSBDdiBjZW50 ZXIgZnJvbnQgdmVydGljYWwgaGVpZ2h0IFRwRkMgdG9wIGZyb250IGNlbnRyZQo+IDIwIEx2ciBs ZWZ0IHN1cnJvdW5kIHZlcnRpY2FsIGhlaWdodCByZWFyIFRwQkwgdG9wIGJhY2sgbGVmdAo+IDIx IFJ2ciByaWdodCBzdXJyb3VuZCB2ZXJ0aWNhbCBoZWlnaHQgcmVhciBUcEJSIHRvcCBiYWNrIHJp Z2h0Cj4gMjIgQ3ZyIGNlbnRlciB2ZXJ0aWNhbCBoZWlnaHQgcmVhciBUcEJDIHRvcCBiYWNrIGNl bnRyZQo+IDIzIEx2c3MgbGVmdCB2ZXJ0aWNhbCBoZWlnaHQgc2lkZSBzdXJyb3VuZCBUcFNpTCB0 b3Agc2lkZSBsZWZ0Cj4gMjQgUnZzcyByaWdodCB2ZXJ0aWNhbCBoZWlnaHQgc2lkZSBzdXJyb3Vu ZCBUcFNpUiB0b3Agc2lkZSByaWdodAo+IDI1IFRzIHRvcCBjZW50ZXIgc3Vycm91bmQgVHBDIHRv cCBjZW50cmUKPiAyNiBMRkUyIGxvdyBmcmVxdWVuY3kgZW5oYW5jZW1lbnQgMiBMRkUyIGxvdyBm cmVxdWVuY3kgZWZmZWN0cy0yCj4gMjcgTGIgbGVmdCBmcm9udCB2ZXJ0aWNhbCBib3R0b20gQnRG TCBib3R0b20gZnJvbnQgbGVmdAo+IDI4IFJiIHJpZ2h0IGZyb250IHZlcnRpY2FsIGJvdHRvbSBC dEZSIGJvdHRvbSBmcm9udCByaWdodAo+IDI5IENiIGNlbnRlciBmcm9udCB2ZXJ0aWNhbCBib3R0 b20gQnRGQyBib3R0b20gZnJvbnQgY2VudHJlCj4gMzAgTHZzIGxlZnQgdmVydGljYWwgaGVpZ2h0 IHN1cnJvdW5kIFRwTFMgdG9wIGxlZnQgc3Vycm91bmQKPiAzMSBSdnMgcmlnaHQgdmVydGljYWwg aGVpZ2h0IHN1cnJvdW5kIFRwUlMgdG9wIHJpZ2h0IHN1cnJvdW5kCj4KPiBUaGlyZCBmaWVsZCBp cyAiTG91ZHNwZWFrZXIgcG9zaXRpb24iLCBsYXN0IGZpZWxkIGlzICJMb3Vkc3BlYWtlcgo+IHBv c2l0aW9uIGFjY29yZGluZyB0byBJRUMgMTAwLzE3MDYvQ0RWL0lFQyA2MjU3NCAoVEMxMDApIiwg ZWFjaCBwcmVmaXhlZCB3aXRoIAo+IGFuIGFiYnJldmlhdGlvbi4KPgo+IEkndmUgYWRkZWQgdGhl IHNvdXJjZSB0byB0aGUgdGFibGUgY29tbWVudCBpbiB0aGUgY29kZS4KPgo+IEkndmUgYWxzbyBm aXhlZCB0aGUgU0lERS9CQUNLL0xGRTIgaXNzdWUgaW4gbXkgZ2l0aHViIHJlcG8gSSBsaW5rZWQg ZWFybGllci4KClRoYW5rcy4gTGF0ZXIgaW4gdGhlIGNvZGUgd2hlbiB5b3UgYWN0dWFsbHkgdXNl IHRoaXMgSSBjYW4gc2VlIHRoYXQgeW91IAphcmUgY3JlYXRpbmcgYSBuYXRpdmUgbGF5b3V0OgoK PiArICAgIGNoYW5uZWxfY29uZmlnX2lkeCA9IGdldF9iaXRzKGdiLCA1KTsgLyogY2hhbm5lbENv bmZpZ3VyYXRpb25JbmRleCAqLwo+ICsgICAgaWYgKCFjaGFubmVsX2NvbmZpZ19pZHgpIHsKPiAr ICAgICAgICAvKiBVc2FjQ2hhbm5lbENvbmZpZygpICovCj4gKyAgICAgICAgdWludDhfdCBjaGFu bmVsX3Bvc1s2NF07Cj4gKyAgICAgICAgdWludDhfdCBuYl9jaGFubmVscyA9IGdldF9lc2NhcGVk X3ZhbHVlKGdiLCA1LCA4LCAxNik7IC8qIG51bU91dENoYW5uZWxzICovCj4gKyAgICAgICAgaWYg KG5iX2NoYW5uZWxzID49IDY0KQo+ICsgICAgICAgICAgICByZXR1cm4gQVZFUlJPUihFSU5WQUwp Owo+ICsKPiArICAgICAgICBhdl9jaGFubmVsX2xheW91dF91bmluaXQoJmFjLT5vY1sxXS5jaF9s YXlvdXQpOwo+ICsgICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbmJfY2hhbm5lbHM7IGkrKykK PiArICAgICAgICAgICAgY2hhbm5lbF9wb3NbaV0gPSBnZXRfYml0cyhnYiwgNSk7IC8qIGJzT3V0 cHV0Q2hhbm5lbFBvcyAqLwo+ICsKPiArICAgICAgICBhYy0+b2NbMV0uY2hfbGF5b3V0Lm9yZGVy ID0gQVZfQ0hBTk5FTF9PUkRFUl9OQVRJVkU7Cj4gKyAgICAgICAgYWMtPm9jWzFdLmNoX2xheW91 dC5uYl9jaGFubmVscyA9IG5iX2NoYW5uZWxzOwo+ICsgICAgICAgIGFjLT5vY1sxXS5jaF9sYXlv dXQudS5tYXNrID0gMDsKPiArCj4gKyAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBuYl9jaGFu bmVsczsgaSsrKQo+ICsgICAgICAgICAgICBhYy0+b2NbMV0uY2hfbGF5b3V0LnUubWFzayB8PSAx IDw8IHVzYWNfY2hfcG9zX3RvX2F2W2NoYW5uZWxfcG9zW2ldXTsKPiArCj4gKyAgICAgICAgYXZf Y2hhbm5lbF9sYXlvdXRfY29weSgmYXZjdHgtPmNoX2xheW91dCwgJmFjLT5vY1sxXS5jaF9sYXlv dXQpOwo+ICsgICAgfSBlbHNlIHsKClByb2JhYmx5IHlvdSBzaG91bGQgY3JlYXRlIGEgY3VzdG9t IGxheW91dCBoZXJlLCBiZWNhdXNlIHRoZSBjaGFubmVscyBhcmUgCm5vdCBuZWNlc3NhcnkgaW4g bmF0aXZlIG9yZGVyLiBXZSBhbHJlYWR5IGhhdmUgYSByZWxhdGl2ZWx5IHNpbXBsZSB3YXkgdG8g CmRvIHRoYXQgYW5kIHRvIGZhbGwgYmFjayB0byBuYXRpdmUgbGF5b3V0cyBpZiBwb3NzaWJsZSwg aGVyZSBpcyBhbiBleGFtcGxlIApjb3BpZWQgZnJvbSBtb3ZfY2hhbjoKCnJldCA9IGF2X2NoYW5u ZWxfbGF5b3V0X2N1c3RvbV9pbml0KGNoX2xheW91dCwgY2hhbm5lbHMpOwppZiAocmV0IDwgMCkK ICAgICByZXR1cm4gcmV0Owpmb3IgKGkgPSAwOyBpIDwgY2hhbm5lbHM7IGkrKykgewogICAgIGVu dW0gQVZDaGFubmVsIGlkID0gbGF5b3V0X21hcFtpXS5pZDsKICAgICBjaF9sYXlvdXQtPnUubWFw W2ldLmlkID0gKGlkICE9IEFWX0NIQU5fTk9ORSA/IGlkIDogQVZfQ0hBTl9VTktOT1dOKTsKfQpy ZXR1cm4gYXZfY2hhbm5lbF9sYXlvdXRfcmV0eXBlKGNoX2xheW91dCwgMCwgQVZfQ0hBTk5FTF9M QVlPVVRfUkVUWVBFX0ZMQUdfQ0FOT05JQ0FMKTsKClNvIHlvdSBzaG91bGQgYWRhcHQgdGhpcyBh Y2NvZGluZ2x5IHRvIGFhYy4KClJlZ2FyZHMsCk1hcnRvbgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpmZm1wZWctZGV2ZWwgbWFpbGluZyBsaXN0CmZmbXBl Zy1kZXZlbEBmZm1wZWcub3JnCmh0dHBzOi8vZmZtcGVnLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Zm bXBlZy1kZXZlbAoKVG8gdW5zdWJzY3JpYmUsIHZpc2l0IGxpbmsgYWJvdmUsIG9yIGVtYWlsCmZm bXBlZy1kZXZlbC1yZXF1ZXN0QGZmbXBlZy5vcmcgd2l0aCBzdWJqZWN0ICJ1bnN1YnNjcmliZSIu Cg==