From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9C4EC48FB3 for ; Tue, 30 Jan 2024 22:07:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5191A68CD10; Wed, 31 Jan 2024 00:07:31 +0200 (EET) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5B50E68CAA2 for ; Wed, 31 Jan 2024 00:07:24 +0200 (EET) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5ca29c131ebso3896412a12.0 for ; Tue, 30 Jan 2024 14:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706652441; x=1707257241; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QVy/eq4e5OlAPnPYm4v5FgTskUZOTNdTXo4LJm4MwFA=; b=ho1WYIibqXyBP3mnYTsuXUwi7WZt4Byq9PnS8L488JPqbxJzkM+Wn+zi0S9rWJiwYI BFMu7aJc/peEfJqjYDBssWLyn8aunDW2yDSrpJMi/so2sdmBSGf0WJzZ4A/0BXtusRIV UvvXBrEvS1kbjU5OHuKSe7Y8VMtdcjyKp6wVT3pAgwlovHSLl5YWG/cJaKyNtmYraBlq NFTTMGasyXBgFkXjEDwc4+6wutnEkwNR7nqdbxYe7xhsTgMvXKmvR1StzUU+aRbiUp0Z nLCfb0E+p5MuYRsDIAXQaEnRxMQTSz+h0TDS2S4+hJLu+GYZBkh22xXVFKfR6k9PJ9gJ ltlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706652441; x=1707257241; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QVy/eq4e5OlAPnPYm4v5FgTskUZOTNdTXo4LJm4MwFA=; b=J1mx5NEWlqx/sRQeUfyacSTtJL6p+VJpb8SuGXml/iJ+b191SsgxWFgmUc5LAnJMAU sAZSvi9vW4jUo1g8CeRAW7+ftAC4/XoifIkkUBYLm/AYNnniYMJ2FinXSN/1BevpdTSB ID5txAIBjkjMK2HzuFAeFhINGoz7agyublqgHCbtIOFBI0dl6jFY0PAUC4B39vlZDuc+ ZEem6ctcWalrUMyhDg3L3jfBA6VbS/J4ETCqf9dwHQ4ZP8DtzrxamTOjjY49a/Rmjr/k ViMjLp7VbwlgmEXoKMQrdQZnm28dLchfKUqH+wIYKSmbtglQlBb/uRa5OMjgpmB4798O jJgQ== X-Gm-Message-State: AOJu0Yzt6mw02YLT8lXSll7Zqg0WlyQnmKbvPGRg0P9LQQv1lv+ap/Oi +et4Ffx8bG2swC+CTxajJ5HgsROHFJHUv5r3ZXCpuuz/iyBqPiF0bIFP2xfc X-Google-Smtp-Source: AGHT+IET0lWAypkwgcaax9NW7mAN2vFquGzbez2+TEmDCJRQCGZ/Gt4RzZCbL0Irq8DgGYm7bzwgNQ== X-Received: by 2002:a05:6a20:cf11:b0:19a:66a4:7966 with SMTP id hy17-20020a056a20cf1100b0019a66a47966mr6668527pzb.55.1706652441328; Tue, 30 Jan 2024 14:07:21 -0800 (PST) Received: from [192.168.0.18] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id t68-20020a625f47000000b006df50bbbaecsm1795753pfb.86.2024.01.30.14.07.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jan 2024 14:07:20 -0800 (PST) Message-ID: Date: Tue, 30 Jan 2024 19:07:44 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240130173218.63297-1-jamrial@gmail.com> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/7 v2] avcodec: add an Immersive Audio Model and Formats frame split bsf X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/30/2024 6:47 PM, Andreas Rheinhardt wrote: >> + *obu_size = get_leb(&gb); > This stuff here should not a GetBitContext at all, as basically > everything is byte-aligned (and the flags above are in known bits). I'm not going to write yet another leb() reading function to work on raw bytes. We have enough scattered around and in fact we should try to remove most. >> +static const enum AVCodecID iamf_stream_split_codec_ids[] = { >> + AV_CODEC_ID_PCM_S16LE, AV_CODEC_ID_PCM_S16BE, >> + AV_CODEC_ID_PCM_S24LE, AV_CODEC_ID_PCM_S24BE, >> + AV_CODEC_ID_PCM_S32LE, AV_CODEC_ID_PCM_S32BE, >> + AV_CODEC_ID_OPUS, AV_CODEC_ID_AAC, >> + AV_CODEC_ID_FLAC, AV_CODEC_ID_NONE, >> +}; >> + >> +const FFBitStreamFilter ff_iamf_stream_split_bsf = { >> + .p.name = "iamf_stream_split", >> + .p.codec_ids = iamf_stream_split_codec_ids, >> + .p.priv_class = &iamf_stream_split_class, >> + .priv_data_size = sizeof(IAMFSplitContext), >> + .init = iamf_stream_split_init, >> + .flush = iamf_stream_split_flush, >> + .close = iamf_stream_split_close, >> + .filter = iamf_stream_split_filter, >> +}; > > This needs to add documentation for what this BSF is actually supposed > to do. Right now it seems crazy: It parses the packet's data and expects > to find OBU headers, although the input data is supposed to be PCM, > Opus, AAC or Flac. It's not too different than aac_adtstoasc in that it takes audio from those codecs listed above encapsulated in one form and returns it in another form. In this case, it takes OBUs containing one or more audio frames, removes the OBU encapsulation, and propagates each raw audio frame in separate packets. I'll write some documentation. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".