From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DD951434D7 for ; Thu, 14 Jul 2022 11:50:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BA48868BA46; Thu, 14 Jul 2022 14:50:11 +0300 (EEST) Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7532C68B9B7 for ; Thu, 14 Jul 2022 14:50:05 +0300 (EEST) Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-10bec750eedso2066572fac.8 for ; Thu, 14 Jul 2022 04:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=jTzoE4bBLhmuz5TAFrY6Oine37yCchtWwxvR/zswWqI=; b=I57JuzdHWOgbz1Yv/rdffVGDdBEEgWnaTZbGVBsvsm57JrOCs3XqmZ9phU6X2NLGFn pka2joU5wSoVD3/02SvnL7NGp5RRT1wPDeOpdc92lKh6G6rUAyuq/S3Th3EdxamkEHF7 Pt9rPrnXHvykgAB24YIGWUdcpv3GKGeKZQM/iH/wLDwJwdNPVgjdEZ+2KuqGcXeAlznR rgOpWfYCrblnt4ltj9M1hVSPKuq3m4GXJ3kRzFL6jB5tasG+kQI21/itmT7JeejXEcka z/kvkRq0jAaQj/IhKH1d0VNBT/buT24F77uuNIf4eJYK7oUNbByEMvLb451WW8zGYn0k 11ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=jTzoE4bBLhmuz5TAFrY6Oine37yCchtWwxvR/zswWqI=; b=qQO5+GcBG8EImdw9Aw0nHAkBv2Sh3FfjubmYZzCl6MpGX1li9qbxhPYGbo+QxRlCLL RcU+g8o4Hlv+sDRmcbIRMZDg2mtP7zkcJ+twMtbN9fmBqX2MWBt5xL4nWXgQc+Hd4wr3 g4GL90joEnaTUoTpdn8QwLao2QEREyLi2ZEiQUEiuJMaSn36yLjfCAE+Im+av3rmkaEB ZM9SVeuKCreFNiDBRlvwwmNbBOtO+aXQMm2/PUKFyJ+FsZNHzo3GKW7Pe1wInfqVfrdL xzCyQNrbskhOPP6yh8YJoNO9YIOSgDcuYOFftcNTmM33v7MvtlIA3CXIw2KXqYmro9hO +NRw== X-Gm-Message-State: AJIora/LHzyaZM7cJAFMDheYrXMcY6UKmuv06mtNolUjJU57YR89a2z2 6Q7KreHT5nGMtlQAuw5MPBJJRynr/sx05w== X-Google-Smtp-Source: AGRyM1seofWS+urXxqvHV7A0RUIwwwXofq4EQca5Cj9HGTzclE6ox0qmtMQU4myZDidHWUtGNuNI/A== X-Received: by 2002:a05:6870:ea87:b0:101:71d1:600a with SMTP id s7-20020a056870ea8700b0010171d1600amr6829528oap.264.1657799403310; Thu, 14 Jul 2022 04:50:03 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.204]) by smtp.gmail.com with ESMTPSA id r81-20020aca4454000000b00339befdfad0sm509368oia.50.2022.07.14.04.50.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jul 2022 04:50:02 -0700 (PDT) Message-ID: Date: Thu, 14 Jul 2022 08:50:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220713091725.16638-1-anton@khirnov.net> <20220713091725.16638-6-anton@khirnov.net> <978501a3-acef-cc0f-f655-ca1401594ad6@gmail.com> <165779127304.25016.8703565613875448010@lain.khirnov.net> From: James Almer In-Reply-To: <165779127304.25016.8703565613875448010@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 6/9] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/14/2022 6:34 AM, Anton Khirnov wrote: > Quoting James Almer (2022-07-13 14:39:20) >> You should probably add new entries to the schema file instead. >> >> https://git.videolan.org/?p=ffmpeg.git;a=blob;f=doc/ffprobe.xsd;h=3af621a17ae884adfeacb7cd50c60e1553808188;hb=HEAD#l93 >> >> Once frame->pkt_duration is gone, ffprobe shouldn't keep printing a >> frame->duration value as "pkt_duration" and "pkt_duration_time". >> Also, if frame->duration is supposed to be able to have values other >> than those we wrote to pkt_duration, maybe keep printing the latter with >> the existing schema entries until it's all gone (You can use >> AV_NOWARN_DEPRECATED() to shut compilers up). > > Well, the whole idea that values printed by ffprobe should precisely > mirror the libav* API, up to the field names of our structs, seems quite > questionable to me, IMO it makes more sense for it to provide a layer of > abstraction over the libraries. But then again I neither maintain > ffprobe, nor use it very much, so I wanted to keep changes to a minimum. > If nobody has other plans for dealing with this then I can certainly > make the changes you're sugesting. ffprobe used to print pkt_pts until it was removed, so printing a field that does not exist (once it's removed) where the new values assigned to it have potentially slightly different semantics than the old ones does not seem like a good idea. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".