Re: [FFmpeg-devel] [PATCH 11/11] avcodec/aac/aacdec_usac: Remove check for impossible sbr_ratio - Lynne via ffmpeg-devel

From: Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne <dev@lynne.ee>
Subject: Re: [FFmpeg-devel] [PATCH 11/11] avcodec/aac/aacdec_usac: Remove check for impossible sbr_ratio
Date: Wed, 3 Jul 2024 02:49:57 +0200
Message-ID: <f070b988-9ccf-4fbf-9146-29ef7532d97c@lynne.ee> (raw)
In-Reply-To: <20240630231306.3779027-11-michael@niedermayer.cc>

[-- Attachment #1.1.1.1: Type: text/plain, Size: 957 bytes --]

On 01/07/2024 01:12, Michael Niedermayer wrote:
> Fixes: CID1605475 Logically dead code
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>   libavcodec/aac/aacdec_usac.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
> index 9587348021e..10121dbc34f 100644
> --- a/libavcodec/aac/aacdec_usac.c
> +++ b/libavcodec/aac/aacdec_usac.c
> @@ -1676,9 +1676,6 @@ int ff_aac_usac_decode_frame(AVCodecContext *avctx, AACDecContext *ac,
>       } else if (sbr_ratio == 3) {
>           ratio_mult = 2;
>           ratio_dec = 1;
> -    } else if (sbr_ratio == 4) {
> -        ratio_mult = 4;
> -        ratio_dec = 1;
>       } else {
>           ratio_mult = 1;
>           ratio_dec = 1;

Its valid, just not supported at the moment. Maybe just error out with 
PATCHWELCOME?
Or mark it as a false positive?

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".