From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/asvenc: Don't waste bits encoding non-visible part
Date: Mon, 26 May 2025 11:31:41 -0300
Message-ID: <f0038c4b-2a77-4db7-85c3-9df2641d1c59@gmail.com> (raw)
In-Reply-To: <GV1P250MB0737797963F90AD2172BDAD18F65A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
[-- Attachment #1.1.1: Type: text/plain, Size: 795 bytes --]
On 5/26/2025 10:22 AM, Andreas Rheinhardt wrote:
> James Almer:
>> On 5/26/2025 10:06 AM, Andreas Rheinhardt wrote:
>>> It is possible to hit this bug even before my patch with a commandline
>>> like this (tested with qemu):
>>> ffmpeg -filter_complex
>>> nullsrc=s=740x576:r=25,format=yuv420p,crop=w=720:x=2 -c:v asv2 -f null -
>>
>> Why does that generate unaligned strides? nullsrc uses
>> ff_get_video_buffer() to allocate a frame, which aligns strides with
>> av_cpu_max_align().
>>
>
> In this example, it is the pointers, not the strides that are unaligned.
Right, the crop filter adds offsets to the data pointers. In that case
I'm leaning towards encoders having to assume non aligned pointers are
possible, and the asv2 encoder fixed to take that into account.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-05-26 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250526015254.3BAED41283C@natalya.videolan.org>
2025-05-26 5:20 ` Martin Storsjö
2025-05-26 13:06 ` Andreas Rheinhardt
2025-05-26 13:21 ` James Almer
2025-05-26 13:22 ` Andreas Rheinhardt
2025-05-26 14:31 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0038c4b-2a77-4db7-85c3-9df2641d1c59@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git