From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F1605497EF for ; Mon, 19 Feb 2024 21:57:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ED10F68D41E; Mon, 19 Feb 2024 23:57:36 +0200 (EET) Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D5ECE68D1FD for ; Mon, 19 Feb 2024 23:57:30 +0200 (EET) Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-6e2e44aad03so2892085a34.2 for ; Mon, 19 Feb 2024 13:57:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708379848; x=1708984648; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=x9FD1HziG7A9EeEvIra7OPW/Gcz0eU5Ja6EH833iAUs=; b=ezQBCaPCQt6VUQSRFFDdgLx7jEsT7ODROZA+J/Phcvdsoqnn42MCOkefinjb8oLNa0 IMPr1V3yvJbRUZgR/3VX3Snn+6Ii9/1xgjWRgmG54VbA+9S8g2udaGEHHDrL2OEwhFbR aSieYyN9BIy6KgJOBZTqBp1eHSJOnI3rbw8Nwx/QKFgvzOP4MBwYBmTO3CBY2kqBXs2z VCRjAxtJkuG7yj6pvl8cObJsUzi1N93cCLo0SpHDfFv8sDpKDFd7wvqG0L4qVh2Z0wDJ /bQi4KNgQXIAFCfMusQpNwRSLOXpcaBftSTpCYA+rZd6UMM7fuqiVp2e9JbPAebXcS9d my2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708379848; x=1708984648; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x9FD1HziG7A9EeEvIra7OPW/Gcz0eU5Ja6EH833iAUs=; b=ev8GMEwJXJplI74h79WYwhNlaGZ49JLnD+GYAt4Yrh6Tol+37MReYzci8zxgU9YAvK pMxVZAkORVm5dYkWn70ppbdAZxt4csDI+TsmL4kOlhSfaagcCgOs4s4Y7CW131K9Uo6C lcD5EWThHjsSEDk99if+A5sL85f/d2s0NGRa6JIb0aTdlPIg+73GfLR+7r4P3BpH6MgW CWvk9KREwF2tNvJvWWKAGeGoJukncWGVerVJUURAKyq6zPiiQ/EkmhMG9j1oyuxrX3sG xhD5TJYhGA8nkEZCpZHnn57BRXqUUKbOXhegpcQ20HlLTfefKRy/h38FuseEkWsE0YDD 9goQ== X-Gm-Message-State: AOJu0Ywqc1odlGVNPrbKoAA8EYH6qxszwafuYD/6IGF9x1DE+4GxJ8BQ vYlcbPdtt/zgmEyL5CIjUI8Jli6BC7DgqGFMqzu4FfYQrfpYpD+DunEtciBO X-Google-Smtp-Source: AGHT+IHxv2sPmvitS4Ek5T8XqYISHo8YtgJoJQIRRkfFtJaKXW/s7Jrt/QRTJUtcg0VWhkroFOcSZw== X-Received: by 2002:a05:6359:4c1a:b0:17a:f91c:825b with SMTP id kj26-20020a0563594c1a00b0017af91c825bmr14459082rwc.5.1708379847921; Mon, 19 Feb 2024 13:57:27 -0800 (PST) Received: from [192.168.0.16] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id fa19-20020a056a002d1300b006e462d99a9esm2529465pfb.143.2024.02.19.13.57.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Feb 2024 13:57:27 -0800 (PST) Message-ID: Date: Mon, 19 Feb 2024 18:57:31 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 3/5] avformat/iamf_writer: Don't memset twice X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/19/2024 6:52 PM, Andreas Rheinhardt wrote: > This has been allocated via av_calloc() a few lines above. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/iamf_writer.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c > index e0c47b5e9d..9a665dc002 100644 > --- a/libavformat/iamf_writer.c > +++ b/libavformat/iamf_writer.c > @@ -251,7 +251,6 @@ int ff_iamf_add_audio_element(IAMFContext *iamf, const AVStreamGroup *stg, void > int nb_channels = iamf_audio_element->layers[i]->ch_layout.nb_channels; > > IAMFLayer *layer = &audio_element->layers[i]; > - memset(layer, 0, sizeof(*layer)); > > if (i) > nb_channels -= iamf_audio_element->layers[i - 1]->ch_layout.nb_channels; LGTM _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".